gaspersic/Gymnasium
1
0
Fork 0
mirror of https://github.com/Farama-Foundation/Gymnasium.git synced 2025-08-23 23:12:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

re-enable and fix atari preprocessing wrappers pixel test (#1652)

Browse Source
This commit is contained in:
pzhokhov
2019-08-23 15:45:55 -07:00
committed by GitHub
parent a0264410f2
commit fd5314780d
2 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gym/wrappers/atari_preprocessing.py
View File

@@ -94,8 +94,7 @@ class AtariPreprocessing(gym.Wrapper):
def reset(self, **kwargs):
# NoopReset
self.env.reset(**kwargs)
noops = self.env.unwrapped.np_random.randint(1, self.noop_max + 1)
assert noops > 0
noops = self.env.unwrapped.np_random.randint(1, self.noop_max + 1) if self.noop_max > 0 else 0
for _ in range(noops):
_, _, done, _ = self.env.step(0)
if done:

31
gym/wrappers/test_atari_preprocessing.py
View File

@@ -1,24 +1,25 @@
import numpy as np
import gym
import pytest
from gym.wrappers import AtariPreprocessing
try:
import atari_py
except ImportError:
atari_py = None
import pytest
pytest.importorskip('atari_py')
@pytest.mark.skipif(atari_py is None, reason='Only run this test when atari_py is installed')
def test_atari_preprocessing():
import cv2
env1 = gym.make('PongNoFrameskip-v0')
env2 = AtariPreprocessing(env1, screen_size=84, grayscale_obs=True)
env3 = AtariPreprocessing(env1, screen_size=84, grayscale_obs=False)
obs1 = env1.reset()
assert obs1.shape == (210, 160, 3)
env_fn = lambda: gym.make('PongNoFrameskip-v4')
env1 = env_fn()
env2 = AtariPreprocessing(env_fn(), screen_size=84, grayscale_obs=True, frame_skip=1, noop_max=0)
env3 = AtariPreprocessing(env_fn(), screen_size=84, grayscale_obs=False, frame_skip=1, noop_max=0)
env1.reset()
# take these steps to imitate actions of FireReset logic
env1.step(1)
obs1 = env1.step(2)[0]
obs2 = env2.reset()
assert obs2.shape == (84, 84)
obs3 = env3.reset()
assert obs1.shape == (210, 160, 3)
assert obs2.shape == (84, 84)
assert obs3.shape == (84, 84, 3)
# TODO peterz - figure out why assertions below are faliing and fix
# np.testing.assert_allclose(obs3, cv2.resize(obs1, (84, 84), interpolation=cv2.INTER_AREA))
# np.testing.assert_allclose(obs2, cv2.cvtColor(obs3, cv2.COLOR_RGB2GRAY))
np.testing.assert_allclose(obs3, cv2.resize(obs1, (84, 84), interpolation=cv2.INTER_AREA))
obs3_gray = cv2.cvtColor(obs3, cv2.COLOR_RGB2GRAY)
# the edges of the numbers do not render quite the same in the grayscale, so we ignore them
np.testing.assert_allclose(obs2[10:], obs3_gray[10:])