Commit Graph

14 Commits

Author SHA1 Message Date
Greg Brockman
8376580c85 Improve closer implementation and docstrings (#126)
* Improve auto close implementation

- Register all envs at initialization time, not just ones created via make
- Simplify names and add more documentation on interface
- Move closer instances into the relevant modules

review-requested: @jietang

* Close environments in the tests

This isn't strictly needed, but means there are fewer Doom
subprocesses hanging around while the tests run.

* Use 4 space indent in comment

* Improve docstrings in core

* Don't pass through args to __new__

The __init__ method gets called once __new__ returns,
so these arguments are either ignored (Python 2) or
result in an error (Python 3). The __init__ method
automatically gets called with the correct arguments.

* Fixup comments
2016-05-27 12:16:35 -07:00
Jie Tang
48c689efea Fix action space warning (fixes #108) 2016-05-23 10:59:42 -07:00
Jie Tang
b92796ae89 Renaming close_registry to closer 2016-05-18 01:27:58 -07:00
Jie Tang
72d29a52f6 Make close() idempotent, add tests, minor fixes 2016-05-16 23:11:50 -07:00
Jie Tang
751dcc15b1 Add close() to Env, add functionality to call close() on exit 2016-05-16 14:58:36 -07:00
JKCooper2
d2d940bddb Cartpole observations can occur outside of observation space limits - Issue #88 (#89)
* Set restriction on selected actions

* Used self.action_space instead of custom set

* Move action validation to core.py

* Fix for Cartpole observations outside of observation_space
2016-05-11 14:50:35 +02:00
Greg Brockman
656646ab37 Stop warning if observation not in observation space 2016-05-10 21:49:39 -07:00
Dominik
da29f0f2f6 Fix observation_space for BipedalWalker (#84)
* Fix observation_space for Bipedal_walker and add warning if observation doesn't fit observation_space

* Remove observation state check on reset.

Multiple environments call reset before action and observation spaces
are initialized.
2016-05-10 20:36:09 -07:00
Greg Brockman
81a4c3e57c Clarify reward docstring
Closes #70
2016-05-08 13:20:01 -07:00
Jonas Schneider
4519a6ffe3 Warn instead of raising on invalid action 2016-05-03 22:27:26 -04:00
JKCooper2
3c983b9f1d Set restriction on selected actions for MountainCar-v0 (#47)
* Set restriction on selected actions

* Used self.action_space instead of custom set

* Move action validation to core.py
2016-05-03 21:40:24 -04:00
Greg Brockman
99f40a2fc1 Add reward_range parameter to Env
Closes #33
2016-04-30 22:53:13 -04:00
Greg Brockman
317a2be993 Update Env docstrings 2016-04-28 10:33:41 -07:00
Greg Brockman
e8f2980603 Initial release. Hello world :). 2016-04-27 08:00:58 -07:00