mirror of
https://github.com/Farama-Foundation/Gymnasium.git
synced 2025-07-31 22:04:31 +00:00
* Added pydocstyle to pre-commit * Added docstrings for tests and updated the tests for autoreset * Add pydocstyle exclude folder to allow slowly adding new docstrings * Add docstrings for setup.py and gym/__init__.py, core.py, error.py and logger.py * Check that all unwrapped environment are of a particular wrapper type * Reverted back to import gym.spaces.Space to gym.spaces * Fixed the __init__.py docstring * Fixed autoreset autoreset test * Updated gym __init__.py top docstring * Fix examples in docstrings * Add docstrings and type hints where known to all functions and classes in gym/utils and gym/vector * Remove unnecessary import * Removed "unused error" and make APIerror deprecated at gym 1.0 * Add pydocstyle description to CONTRIBUTING.md * Added docstrings section to CONTRIBUTING.md * Added :meth: and :attr: keywords to docstrings * Added :meth: and :attr: keywords to docstrings * Imported annotations from __future__ to fix python 3.7 * Add __future__ import annotations for python 3.7 * isort * Remove utils and vectors for this PR and spaces for previous PR * Update gym/envs/classic_control/acrobot.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/envs/classic_control/acrobot.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/envs/classic_control/acrobot.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/spaces/dict.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/env_checker.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/env_checker.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/env_checker.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/env_checker.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/env_checker.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/ezpickle.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/ezpickle.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Update gym/utils/play.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Pre-commit * Updated docstrings with :meth: * Updated docstrings with :meth: * Update gym/utils/play.py * Update gym/utils/play.py * Update gym/utils/play.py * Apply suggestions from code review Co-authored-by: Markus Krimmel <montcyril@gmail.com> * pre-commit * Update gym/utils/play.py Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Updated fps and zoom parameter docstring * Update play docstring * Apply suggestions from code review Added suggested corrections from @markus28 Co-authored-by: Markus Krimmel <montcyril@gmail.com> * Pre-commit magic * Update the `gym.make` docstring with a warning for `env_checker` * Updated and fixed vector docstrings * Update test names for reflect the project filename style Co-authored-by: Markus Krimmel <montcyril@gmail.com>
469 lines
18 KiB
Python
469 lines
18 KiB
Python
"""A set of functions for checking an environment details.
|
|
|
|
This file is originally from the Stable Baselines3 repository hosted on GitHub
|
|
(https://github.com/DLR-RM/stable-baselines3/)
|
|
Original Author: Antonin Raffin
|
|
|
|
It also uses some warnings/assertions from the PettingZoo repository hosted on GitHub
|
|
(https://github.com/PettingZoo-Team/PettingZoo)
|
|
Original Author: J K Terry
|
|
|
|
These projects are covered by the MIT License.
|
|
"""
|
|
|
|
import inspect
|
|
from typing import Optional, Union
|
|
|
|
import numpy as np
|
|
|
|
import gym
|
|
from gym import logger
|
|
from gym.spaces import Box, Dict, Discrete, Space, Tuple
|
|
|
|
|
|
def _is_numpy_array_space(space: Space) -> bool:
|
|
"""Checks if a space can be represented as a single numpy array (e.g. Dict and Tuple spaces return False).
|
|
|
|
Args:
|
|
space: The space to check
|
|
|
|
Returns:
|
|
Returns False if the provided space is not representable as a single numpy array
|
|
"""
|
|
return not isinstance(space, (Dict, Tuple))
|
|
|
|
|
|
def _check_image_input(observation_space: Box, key: str = ""):
|
|
"""Check whether an observation space of type :class:`Box` adheres to general standards for spaces that represent images.
|
|
|
|
It will check that:
|
|
- The datatype is ``np.uint8``
|
|
- The lower bound is 0 across all dimensions
|
|
- The upper bound is 255 across all dimensions
|
|
|
|
Args:
|
|
observation_space: The observation space to check
|
|
key: The observation shape key for warning
|
|
"""
|
|
if observation_space.dtype != np.uint8:
|
|
logger.warn(
|
|
f"It seems that your observation {key} is an image but the `dtype` "
|
|
"of your observation_space is not `np.uint8`. "
|
|
"If your observation is not an image, we recommend you to flatten the observation "
|
|
"to have only a 1D vector"
|
|
)
|
|
|
|
if np.any(observation_space.low != 0) or np.any(observation_space.high != 255):
|
|
logger.warn(
|
|
f"It seems that your observation space {key} is an image but the "
|
|
"upper and lower bounds are not in [0, 255]. "
|
|
"Generally, CNN policies assume observations are within that range, "
|
|
"so you may encounter an issue if the observation values are not."
|
|
)
|
|
|
|
|
|
def _check_nan(env: gym.Env, check_inf: bool = True):
|
|
"""Check if the environment observation, reward are NaN and Inf.
|
|
|
|
Args:
|
|
env: The environment to check
|
|
check_inf: Checks if the observation is infinity
|
|
"""
|
|
for _ in range(10):
|
|
action = env.action_space.sample()
|
|
observation, reward, done, _ = env.step(action)
|
|
|
|
if done:
|
|
env.reset()
|
|
|
|
if np.any(np.isnan(observation)):
|
|
logger.warn("Encountered NaN value in observations.")
|
|
if np.any(np.isnan(reward)):
|
|
logger.warn("Encountered NaN value in rewards.")
|
|
if check_inf and np.any(np.isinf(observation)):
|
|
logger.warn("Encountered inf value in observations.")
|
|
if check_inf and np.any(np.isinf(reward)):
|
|
logger.warn("Encountered inf value in rewards.")
|
|
|
|
|
|
def _check_obs(
|
|
obs: Union[tuple, dict, np.ndarray, int],
|
|
observation_space: Space,
|
|
method_name: str,
|
|
):
|
|
"""Check that the observation returned by the environment correspond to the declared one.
|
|
|
|
Args:
|
|
obs: The observation to check
|
|
observation_space: The observation space of the observation
|
|
method_name: The method name that generated the observation
|
|
"""
|
|
if not isinstance(observation_space, Tuple):
|
|
assert not isinstance(
|
|
obs, tuple
|
|
), f"The observation returned by the `{method_name}()` method should be a single value, not a tuple"
|
|
|
|
if isinstance(observation_space, Discrete):
|
|
assert isinstance(
|
|
obs, int
|
|
), f"The observation returned by `{method_name}()` method must be an int"
|
|
elif _is_numpy_array_space(observation_space):
|
|
assert isinstance(
|
|
obs, np.ndarray
|
|
), f"The observation returned by `{method_name}()` method must be a numpy array"
|
|
|
|
assert observation_space.contains(
|
|
obs
|
|
), f"The observation returned by the `{method_name}()` method does not match the given observation space"
|
|
|
|
|
|
def _check_box_obs(observation_space: Box, key: str = ""):
|
|
"""Check that the observation space is correctly formatted when dealing with a :class:`Box` space.
|
|
|
|
In particular, it checks:
|
|
- that the dimensions are big enough when it is an image, and that the type matches
|
|
- that the observation has an expected shape (warn the user if not)
|
|
|
|
Args:
|
|
observation_space: Checks if the Box observation space
|
|
key: The observation key
|
|
"""
|
|
# If image, check the low and high values, the type and the number of channels
|
|
# and the shape (minimal value)
|
|
if len(observation_space.shape) == 3:
|
|
_check_image_input(observation_space)
|
|
|
|
if len(observation_space.shape) not in [1, 3]:
|
|
logger.warn(
|
|
f"Your observation {key} has an unconventional shape (neither an image, nor a 1D vector). "
|
|
"We recommend you to flatten the observation "
|
|
"to have only a 1D vector or use a custom policy to properly process the data."
|
|
)
|
|
|
|
if np.any(np.equal(observation_space.low, -np.inf)):
|
|
logger.warn(
|
|
"Agent's minimum observation space value is -infinity. This is probably too low."
|
|
)
|
|
if np.any(np.equal(observation_space.high, np.inf)):
|
|
logger.warn(
|
|
"Agent's maxmimum observation space value is infinity. This is probably too high"
|
|
)
|
|
if np.any(np.equal(observation_space.low, observation_space.high)):
|
|
logger.warn("Agent's maximum and minimum observation space values are equal")
|
|
if np.any(np.greater(observation_space.low, observation_space.high)):
|
|
assert False, "Agent's minimum observation value is greater than it's maximum"
|
|
if observation_space.low.shape != observation_space.shape:
|
|
assert (
|
|
False
|
|
), "Agent's observation_space.low and observation_space have different shapes"
|
|
if observation_space.high.shape != observation_space.shape:
|
|
assert (
|
|
False
|
|
), "Agent's observation_space.high and observation_space have different shapes"
|
|
|
|
|
|
def _check_box_action(action_space: Box):
|
|
"""Checks that a :class:`Box` action space is defined in a sensible way.
|
|
|
|
Args:
|
|
action_space: A box action space
|
|
"""
|
|
if np.any(np.equal(action_space.low, -np.inf)):
|
|
logger.warn(
|
|
"Agent's minimum action space value is -infinity. This is probably too low."
|
|
)
|
|
if np.any(np.equal(action_space.high, np.inf)):
|
|
logger.warn(
|
|
"Agent's maximum action space value is infinity. This is probably too high"
|
|
)
|
|
if np.any(np.equal(action_space.low, action_space.high)):
|
|
logger.warn("Agent's maximum and minimum action space values are equal")
|
|
if np.any(np.greater(action_space.low, action_space.high)):
|
|
assert False, "Agent's minimum action value is greater than it's maximum"
|
|
if action_space.low.shape != action_space.shape:
|
|
assert False, "Agent's action_space.low and action_space have different shapes"
|
|
if action_space.high.shape != action_space.shape:
|
|
assert False, "Agent's action_space.high and action_space have different shapes"
|
|
|
|
|
|
def _check_normalized_action(action_space: Box):
|
|
"""Checks that a box action space is normalized.
|
|
|
|
Args:
|
|
action_space: A box action space
|
|
"""
|
|
if (
|
|
np.any(np.abs(action_space.low) != np.abs(action_space.high))
|
|
or np.any(np.abs(action_space.low) > 1)
|
|
or np.any(np.abs(action_space.high) > 1)
|
|
):
|
|
logger.warn(
|
|
"We recommend you to use a symmetric and normalized Box action space (range=[-1, 1]) "
|
|
"cf https://stable-baselines3.readthedocs.io/en/master/guide/rl_tips.html"
|
|
)
|
|
|
|
|
|
def _check_returned_values(env: gym.Env, observation_space: Space, action_space: Space):
|
|
"""Check the returned values by the env when calling :meth:`env.reset` or :meth:`env.step` methods.
|
|
|
|
Args:
|
|
env: The environment
|
|
observation_space: The environment's observation space
|
|
action_space: The environment's action space
|
|
"""
|
|
# because env inherits from gym.Env, we assume that `reset()` and `step()` methods exists
|
|
obs = env.reset()
|
|
|
|
if isinstance(observation_space, Dict):
|
|
assert isinstance(
|
|
obs, dict
|
|
), "The observation returned by `reset()` must be a dictionary"
|
|
for key in observation_space.spaces.keys():
|
|
try:
|
|
_check_obs(obs[key], observation_space.spaces[key], "reset")
|
|
except AssertionError as e:
|
|
raise AssertionError(f"Error while checking key={key}: " + str(e))
|
|
else:
|
|
_check_obs(obs, observation_space, "reset")
|
|
|
|
# Sample a random action
|
|
action = action_space.sample()
|
|
data = env.step(action)
|
|
|
|
assert (
|
|
len(data) == 4
|
|
), "The `step()` method must return four values: obs, reward, done, info"
|
|
|
|
# Unpack
|
|
obs, reward, done, info = data
|
|
|
|
if isinstance(observation_space, Dict):
|
|
assert isinstance(
|
|
obs, dict
|
|
), "The observation returned by `step()` must be a dictionary"
|
|
for key in observation_space.spaces.keys():
|
|
try:
|
|
_check_obs(obs[key], observation_space.spaces[key], "step")
|
|
except AssertionError as e:
|
|
raise AssertionError(f"Error while checking key={key}: " + str(e))
|
|
|
|
else:
|
|
_check_obs(obs, observation_space, "step")
|
|
|
|
# We also allow int because the reward will be cast to float
|
|
assert isinstance(
|
|
reward, (float, int, np.float32)
|
|
), "The reward returned by `step()` must be a float"
|
|
assert isinstance(done, bool), "The `done` signal must be a boolean"
|
|
assert isinstance(
|
|
info, dict
|
|
), "The `info` returned by `step()` must be a python dictionary"
|
|
|
|
|
|
def _check_spaces(env: gym.Env):
|
|
"""Check that the observation and action spaces are defined and inherit from :class:`gym.spaces.Space`.
|
|
|
|
Args:
|
|
env: The environment's observation and action space to check
|
|
"""
|
|
# Helper to link to the code, because gym has no proper documentation
|
|
gym_spaces = " cf https://github.com/openai/gym/blob/master/gym/spaces/"
|
|
|
|
assert hasattr(env, "observation_space"), (
|
|
"You must specify an observation space (cf gym.spaces)" + gym_spaces
|
|
)
|
|
assert hasattr(env, "action_space"), (
|
|
"You must specify an action space (cf gym.spaces)" + gym_spaces
|
|
)
|
|
|
|
assert isinstance(env.observation_space, Space), (
|
|
"The observation space must inherit from gym.spaces" + gym_spaces
|
|
)
|
|
assert isinstance(env.action_space, Space), (
|
|
"The action space must inherit from gym.spaces" + gym_spaces
|
|
)
|
|
|
|
|
|
# Check render cannot be covered by CI
|
|
def _check_render(env: gym.Env, warn: bool = True, headless: bool = False):
|
|
"""Check the declared render modes/fps and the :meth:`render`/:meth:`close` method of the environment.
|
|
|
|
Args:
|
|
env: The environment to check
|
|
warn: Whether to output additional warnings
|
|
headless: Whether to disable render modes that require a graphical interface. False by default.
|
|
"""
|
|
render_modes = env.metadata.get("render_modes")
|
|
if render_modes is None:
|
|
if warn:
|
|
logger.warn(
|
|
"No render modes was declared in the environment "
|
|
" (env.metadata['render_modes'] is None or not defined), "
|
|
"you may have trouble when calling `.render()`"
|
|
)
|
|
|
|
render_fps = env.metadata.get("render_fps")
|
|
# We only require `render_fps` if rendering is actually implemented
|
|
if render_fps is None and render_modes is not None and len(render_modes) > 0:
|
|
if warn:
|
|
logger.warn(
|
|
"No render fps was declared in the environment "
|
|
" (env.metadata['render_fps'] is None or not defined), "
|
|
"rendering may occur at inconsistent fps"
|
|
)
|
|
|
|
else:
|
|
# Don't check render mode that require a
|
|
# graphical interface (useful for CI)
|
|
if headless and "human" in render_modes:
|
|
render_modes.remove("human")
|
|
# Check all declared render modes
|
|
for render_mode in render_modes:
|
|
env.render(mode=render_mode)
|
|
env.close()
|
|
|
|
|
|
def _check_reset_seed(env: gym.Env, seed: Optional[int] = None):
|
|
"""Check that the environment can be reset with a seed.
|
|
|
|
Args:
|
|
env: The environment to check
|
|
seed: The optional seed to use
|
|
"""
|
|
signature = inspect.signature(env.reset)
|
|
assert (
|
|
"seed" in signature.parameters or "kwargs" in signature.parameters
|
|
), "The environment cannot be reset with a random seed. This behavior will be deprecated in the future."
|
|
|
|
try:
|
|
env.reset(seed=seed)
|
|
except TypeError as e:
|
|
raise AssertionError(
|
|
"The environment cannot be reset with a random seed, even though `seed` or `kwargs` "
|
|
"appear in the signature. This should never happen, please report this issue. "
|
|
f"The error was: {e}"
|
|
)
|
|
|
|
if env.unwrapped.np_random is None:
|
|
logger.warn(
|
|
"Resetting the environment did not result in seeding its random number generator. "
|
|
"This is likely due to not calling `super().reset(seed=seed)` in the `reset` method. "
|
|
"If you do not use the python-level random number generator, this is not a problem."
|
|
)
|
|
|
|
seed_param = signature.parameters.get("seed")
|
|
# Check the default value is None
|
|
if seed_param is not None and seed_param.default is not None:
|
|
logger.warn(
|
|
"The default seed argument in reset should be `None`, "
|
|
"otherwise the environment will by default always be deterministic"
|
|
)
|
|
|
|
|
|
def _check_reset_info(env: gym.Env):
|
|
"""Checks that :meth:`reset` supports the ``return_info`` keyword.
|
|
|
|
Args:
|
|
env: The environment to check
|
|
"""
|
|
signature = inspect.signature(env.reset)
|
|
assert (
|
|
"return_info" in signature.parameters or "kwargs" in signature.parameters
|
|
), "The `reset` method does not provide the `return_info` keyword argument"
|
|
|
|
try:
|
|
result = env.reset(return_info=True)
|
|
except TypeError as e:
|
|
raise AssertionError(
|
|
"The environment cannot be reset with `return_info=True`, even though `return_info` or `kwargs` "
|
|
"appear in the signature. This should never happen, please report this issue. "
|
|
f"The error was: {e}"
|
|
)
|
|
assert (
|
|
len(result) == 2
|
|
), "Calling the reset method with `return_info=True` did not return a 2-tuple"
|
|
|
|
obs, info = result
|
|
assert isinstance(
|
|
info, dict
|
|
), "The second element returned by `env.reset(return_info=True)` was not a dictionary"
|
|
|
|
|
|
def _check_reset_options(env: gym.Env):
|
|
"""Check that the environment can be reset with options.
|
|
|
|
Args:
|
|
env: The environment to check
|
|
"""
|
|
signature = inspect.signature(env.reset)
|
|
assert (
|
|
"options" in signature.parameters or "kwargs" in signature.parameters
|
|
), "The environment cannot be reset with options. This behavior will be deprecated in the future."
|
|
|
|
try:
|
|
env.reset(options={})
|
|
except TypeError as e:
|
|
raise AssertionError(
|
|
"The environment cannot be reset with options, even though `options` or `kwargs` "
|
|
"appear in the signature. This should never happen, please report this issue. "
|
|
f"The error was: {e}"
|
|
)
|
|
|
|
|
|
def check_env(env: gym.Env, warn: bool = True, skip_render_check: bool = True):
|
|
"""Check that an environment follows Gym API.
|
|
|
|
This is particularly useful when using a custom environment.
|
|
Please take a look at https://github.com/openai/gym/blob/master/gym/core.py
|
|
for more information about the API.
|
|
It also optionally check that the environment is compatible with Stable-Baselines.
|
|
|
|
Args:
|
|
env: The Gym environment that will be checked
|
|
warn: Whether to output additional warnings mainly related to the interaction with Stable Baselines
|
|
skip_render_check: Whether to skip the checks for the render method. True by default (useful for the CI)
|
|
"""
|
|
assert isinstance(
|
|
env, gym.Env
|
|
), "Your environment must inherit from the gym.Env class cf https://github.com/openai/gym/blob/master/gym/core.py"
|
|
|
|
# ============= Check the spaces (observation and action) ================
|
|
_check_spaces(env)
|
|
# Define aliases for convenience
|
|
observation_space = env.observation_space
|
|
action_space = env.action_space
|
|
|
|
# Warn the user if needed.
|
|
# A warning means that the environment may run but not work properly with popular RL libraries.
|
|
if warn:
|
|
obs_spaces = (
|
|
observation_space.spaces
|
|
if isinstance(observation_space, Dict)
|
|
else {"": observation_space}
|
|
)
|
|
for key, space in obs_spaces.items():
|
|
if isinstance(space, Box):
|
|
_check_box_obs(space, key)
|
|
|
|
# Check for the action space, it may lead to hard-to-debug issues
|
|
if isinstance(action_space, Box):
|
|
_check_box_action(action_space)
|
|
_check_normalized_action(action_space)
|
|
|
|
# ============ Check the returned values ===============
|
|
_check_returned_values(env, observation_space, action_space)
|
|
|
|
# ==== Check the render method and the declared render modes ====
|
|
if not skip_render_check:
|
|
_check_render(env, warn=warn) # pragma: no cover
|
|
|
|
# The check only works with numpy arrays
|
|
if _is_numpy_array_space(observation_space) and _is_numpy_array_space(action_space):
|
|
_check_nan(env)
|
|
|
|
# ==== Check the reset method ====
|
|
_check_reset_seed(env)
|
|
_check_reset_seed(env, seed=0)
|
|
_check_reset_options(env)
|
|
_check_reset_info(env)
|