Files

60 lines
1.0 KiB
Markdown
Raw Permalink Normal View History

---
id: 5f332b23c2045fb843337579
title: Step 7
challengeType: 0
dashedName: step-7
---
# --description--
Since the `p` element added in the previous step provides supplemental information about the cafe, nest both the `h1` and `p` elements in a `header` element.
# --hints--
feat: CSS Cafe Menu (#41797) * fix: general bugs - Ensure editable region at end of code-block is followed by a blank line. - Remove apparent duplicate step. - Address spelling issues. * feat: some tests * feat: tests 6-20 Add tests for steps 6-20. * feat: tests 21-30 Add tests for steps 21 through 30. * feat: tests 31-40 Add tests for steps 31 through 40. * feat: tests 41-50 Add tests for steps 41 through 50. * feat: tests 51-60 Add tests for steps 51 through 60. * feat: tests 61-70 Add tests for steps 61 through 70. * feat: tests 71-80 Add tests for steps 71 through 80. * feat: steps 81-92 Add tests for steps 81 through 92. * feat: align dashed names Align the dashed names with the titles and file names. * fix: apply gikf's suggestions Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * fix: manual review suggestions Apply gikf's other suggestions. * feat: more thorough testing When a test asserts that a camper adds a new element relative to an existing element, also test that the existing element is not malformed. * feat: optional semi colons Make EOL semi-colons optional in the CSS. If they're missing and the CSS doesn't render correctly, other tests will catch that. If they are on the last property of the ruleset, they technically aren't required so we shouldn't require them? * chore: apply review suggestions Apply review suggestions from gikf Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * chore: apply suggestions from code review Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * feat: review suggestions Apply Ahmad's review suggestions. * chore: additional suggestions Manual application of Ahmad's review suggestions. Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> * chore: apply suggestions from code review Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> * chore: apply shaun's review suggestions Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> * feat: add clarification Add a bit of text clarifying the file switch in the editor. * chore: replace URLs Replace the tinyurls with our self-hosted CDN images. * feat: new CSS tests Re-write CSS tests with new parser. * fix: grammar Apply Shaun's grammar reviews. Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> * fix: optional chaining * chore: apply suggestions from code review Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * chore: apply reviews manually * chore: getStyle update Replace getStyleDeclaration with getStyle. * fix: resolve test issue * chore: remove jQuery :( Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * chore: apply suggestions from code review Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md Co-authored-by: Tom <20648924+moT01@users.noreply.github.com> Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-21 12:03:09 -07:00
You should have an opening `<header>` tag.
```js
feat: CSS Cafe Menu (#41797) * fix: general bugs - Ensure editable region at end of code-block is followed by a blank line. - Remove apparent duplicate step. - Address spelling issues. * feat: some tests * feat: tests 6-20 Add tests for steps 6-20. * feat: tests 21-30 Add tests for steps 21 through 30. * feat: tests 31-40 Add tests for steps 31 through 40. * feat: tests 41-50 Add tests for steps 41 through 50. * feat: tests 51-60 Add tests for steps 51 through 60. * feat: tests 61-70 Add tests for steps 61 through 70. * feat: tests 71-80 Add tests for steps 71 through 80. * feat: steps 81-92 Add tests for steps 81 through 92. * feat: align dashed names Align the dashed names with the titles and file names. * fix: apply gikf's suggestions Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * fix: manual review suggestions Apply gikf's other suggestions. * feat: more thorough testing When a test asserts that a camper adds a new element relative to an existing element, also test that the existing element is not malformed. * feat: optional semi colons Make EOL semi-colons optional in the CSS. If they're missing and the CSS doesn't render correctly, other tests will catch that. If they are on the last property of the ruleset, they technically aren't required so we shouldn't require them? * chore: apply review suggestions Apply review suggestions from gikf Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * chore: apply suggestions from code review Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * feat: review suggestions Apply Ahmad's review suggestions. * chore: additional suggestions Manual application of Ahmad's review suggestions. Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> * chore: apply suggestions from code review Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> * chore: apply shaun's review suggestions Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> * feat: add clarification Add a bit of text clarifying the file switch in the editor. * chore: replace URLs Replace the tinyurls with our self-hosted CDN images. * feat: new CSS tests Re-write CSS tests with new parser. * fix: grammar Apply Shaun's grammar reviews. Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> * fix: optional chaining * chore: apply suggestions from code review Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * chore: apply reviews manually * chore: getStyle update Replace getStyleDeclaration with getStyle. * fix: resolve test issue * chore: remove jQuery :( Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * chore: apply suggestions from code review Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md Co-authored-by: Tom <20648924+moT01@users.noreply.github.com> Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-21 12:03:09 -07:00
assert(code.match(/<header>/i));
```
You should have a closing `</header>` tag.
```js
assert(code.match(/<\/header>/i));
```
Your `h1` element should be nested in your `header` element.
feat: CSS Cafe Menu (#41797) * fix: general bugs - Ensure editable region at end of code-block is followed by a blank line. - Remove apparent duplicate step. - Address spelling issues. * feat: some tests * feat: tests 6-20 Add tests for steps 6-20. * feat: tests 21-30 Add tests for steps 21 through 30. * feat: tests 31-40 Add tests for steps 31 through 40. * feat: tests 41-50 Add tests for steps 41 through 50. * feat: tests 51-60 Add tests for steps 51 through 60. * feat: tests 61-70 Add tests for steps 61 through 70. * feat: tests 71-80 Add tests for steps 71 through 80. * feat: steps 81-92 Add tests for steps 81 through 92. * feat: align dashed names Align the dashed names with the titles and file names. * fix: apply gikf's suggestions Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * fix: manual review suggestions Apply gikf's other suggestions. * feat: more thorough testing When a test asserts that a camper adds a new element relative to an existing element, also test that the existing element is not malformed. * feat: optional semi colons Make EOL semi-colons optional in the CSS. If they're missing and the CSS doesn't render correctly, other tests will catch that. If they are on the last property of the ruleset, they technically aren't required so we shouldn't require them? * chore: apply review suggestions Apply review suggestions from gikf Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * chore: apply suggestions from code review Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> * feat: review suggestions Apply Ahmad's review suggestions. * chore: additional suggestions Manual application of Ahmad's review suggestions. Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> * chore: apply suggestions from code review Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> * chore: apply shaun's review suggestions Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> * feat: add clarification Add a bit of text clarifying the file switch in the editor. * chore: replace URLs Replace the tinyurls with our self-hosted CDN images. * feat: new CSS tests Re-write CSS tests with new parser. * fix: grammar Apply Shaun's grammar reviews. Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> * fix: optional chaining * chore: apply suggestions from code review Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * chore: apply reviews manually * chore: getStyle update Replace getStyleDeclaration with getStyle. * fix: resolve test issue * chore: remove jQuery :( Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * chore: apply suggestions from code review Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> * fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md Co-authored-by: Tom <20648924+moT01@users.noreply.github.com> Co-authored-by: gikf <60067306+gikf@users.noreply.github.com> Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com> Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com> Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-21 12:03:09 -07:00
```js
const header = document.querySelectorAll('header')[0];
assert(header.children[0].tagName === 'H1');
```
Your `p` element should be nested in your `header` element.
```js
const header = document.querySelectorAll('header')[0];
assert(header.children[1].tagName === "P");
```
# --seed--
## --seed-contents--
```html
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<title>Cafe Menu</title>
</head>
<body>
--fcc-editable-region--
<h1>CAMPER CAFE</h1>
<p>Est. 2020</p>
--fcc-editable-region--
</body>
<html>
```