gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(client): show error messages instead of timeout (#43744)

Browse Source 
* Fixed Error message update not displaying when timeout happens when there was an error in the code. Working on fixing the timeout it self.

* refactor: remove comment + log changes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
This commit is contained in:
Jacob O'Reilly
2022-01-08 07:25:38 -08:00
committed by GitHub
parent c8146f031e
commit 0009100f71
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/templates/Challenges/redux/execute-challenge-saga.js
View File

@ -225,10 +225,10 @@ function* previewChallengeSaga({ flushLogs = true } = {}) {
}
}
} catch (err) {
if (err === 'timeout') {
if (err[0] === 'timeout') {
// TODO: translate the error
// eslint-disable-next-line no-ex-assign
err = `The code you have written is taking longer than the ${previewTimeout}ms our challenges allow. You may have created an infinite loop or need to write a more efficient algorithm`;
err[0] = `The code you have written is taking longer than the ${previewTimeout}ms our challenges allow. You may have created an infinite loop or need to write a more efficient algorithm`;
}
console.log(err);
yield put(updateConsole(escape(err)));