gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix cannot read property id of user durring upvote

Browse Source 
post to upvote without auth returns 401
This commit is contained in:
Berkeley Martinez
2015-08-18 19:48:42 -07:00
parent 8c803281f6
commit 0128829d11
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
server/boot/story.js
View File

@ -18,6 +18,7 @@ var time48Hours = 172800000;
var unDasherize = utils.unDasherize; var unDasherize = utils.unDasherize;
var dasherize = utils.dasherize; var dasherize = utils.dasherize;
var getURLTitle = utils.getURLTitle; var getURLTitle = utils.getURLTitle;
var ifNoUser401 = require('../utils/middleware').ifNoUser401;
function hotRank(timeValue, rank) { function hotRank(timeValue, rank) {
/* /*
@ -63,12 +64,12 @@ module.exports = function(app) {
router.get('/stories/hotStories', hotJSON); router.get('/stories/hotStories', hotJSON);
router.get('/stories/submit', submitNew); router.get('/stories/submit', submitNew);
router.get('/stories/submit/new-story', preSubmit); router.get('/stories/submit/new-story', preSubmit);
router.post('/stories/preliminary', newStory); router.post('/stories/preliminary', ifNoUser401, newStory);
router.post('/stories/', storySubmission); router.post('/stories/', ifNoUser401, storySubmission);
router.get('/news/', hot); router.get('/news/', hot);
router.post('/stories/search', getStories); router.post('/stories/search', getStories);
router.get('/news/:storyName', returnIndividualStory); router.get('/news/:storyName', returnIndividualStory);
router.post('/stories/upvote/', upvote); router.post('/stories/upvote/', ifNoUser401, upvote);
router.get('/stories/:storyName', redirectToNews); router.get('/stories/:storyName', redirectToNews);
app.use(router); app.use(router);

11
server/utils/middleware.js
View File

@ -12,12 +12,12 @@ exports.userMigration = function userMigration(req, res, next) {
if (!req.user || req.user.completedChallenges.length !== 0) { if (!req.user || req.user.completedChallenges.length !== 0) {
return next(); return next();
} }
req.user.completedChallenges = R.filter(function (elem) { req.user.completedChallenges = R.filter(function(elem) {
// getting rid of undefined // getting rid of undefined
return elem; return elem;
}, R.concat( }, R.concat(
req.user.completedCoursewares, req.user.completedCoursewares,
req.user.completedBonfires.map(function (bonfire) { req.user.completedBonfires.map(function(bonfire) {
return ({ return ({
completedDate: bonfire.completedDate, completedDate: bonfire.completedDate,
id: bonfire.id, id: bonfire.id,
@ -51,3 +51,10 @@ exports.ifNoUserSend = function ifNoUserSend(sendThis) {
return res.status(200).send(sendThis); return res.status(200).send(sendThis);
}; };
}; };
exports.ifNoUser401 = function ifNoUser401(req, res, next) {
if (req.user) {
return next();
}
return res.status(401).end();
};