gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(client): remove url parameters from forum href (#44157)

Browse Source 
* fix(client): remove url parameters from forum href

* add tests for removeUrlParamters

* use URL API, Shaun's preferred method
This commit is contained in:
Shaun Hamilton
2021-11-11 21:57:26 +00:00
committed by GitHub
parent 95923c11c7
commit 0b362380d4
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
client/src/templates/Challenges/redux/create-question-epic.js
View File

@ -38,8 +38,10 @@ function createQuestionEpic(action$, state$, { window }) {
challengeMetaSelector(state); challengeMetaSelector(state);
const { const {
navigator: { userAgent }, navigator: { userAgent },
location: { href } location: { pathname, origin }
} = window; } = window;
// Removes query params
const challengeUrl = new URL(pathname, origin).href;
const projectFormValues = Object.entries( const projectFormValues = Object.entries(
projectFormValuesSelector(state) projectFormValuesSelector(state)
); );
@ -51,7 +53,7 @@ function createQuestionEpic(action$, state$, { window }) {
'forum-help.challenge' 'forum-help.challenge'
)} ${challengeTitle}\n\n${i18next.t( )} ${challengeTitle}\n\n${i18next.t(
'forum-help.challenge-link' 'forum-help.challenge-link'
)}\n${href}` )}\n${challengeUrl}`
); );
let textMessage = dedent(`${i18next.t( let textMessage = dedent(`${i18next.t(