refactor(services/use): Simplify logic declaritively

server/services/user.js

@@ -1,5 +1,7 @@
-import debug from 'debug';
 import _ from 'lodash';
+// import debug from 'debug';
+// use old rxjs
+import { Observable } from 'rx';
 
 const publicUserProps = [
   'id',
@@ -35,21 +37,20 @@ const publicUserProps = [
   'currentChallengeId',
   'challengeMap'
 ];
-const log = debug('fcc:services:user');
+
+// const log = debug('fcc:services:user');
 
 export default function userServices() {
   return {
     name: 'user',
     read: (req, resource, params, config, cb) => {
-      let { user } = req;
+      const { user } = req;
-      if (user) {
+      Observable.if(
-        log('user is signed in');
+        () => !user,
-        return user.getChallengeMap$()
+        Observable.of({}),
+        user.getChallengeMap$()
           .map(challengeMap => ({ ...user.toJSON(), challengeMap }))
-          .subscribe(
+          .map(user => ({
-            user => cb(
-              null,
-              {
             entities: {
               user: {
                 [user.username]: {
@@ -60,16 +61,12 @@ export default function userServices() {
               }
             },
             result: user.username
-              }
+          }))
-            ),
+      )
+        .subscribe(
+          user => cb(null, user),
           cb
         );
     }
-      debug('user is not signed in');
-      // Zalgo!!!
-      return process.nextTick(() => {
-        cb(null, {});
-      });
-    }
   };
 }