fix(settings): Lang attribute warnings

This commit is contained in:
Berkeley Martinez
2017-01-08 20:33:00 -08:00
parent dcb2c93497
commit 0cd2e9b390

View File

@ -7,6 +7,12 @@ import { updateMyLang } from '../redux/actions';
import { userSelector } from '../../../redux/selectors'; import { userSelector } from '../../../redux/selectors';
import langs from '../../../../utils/supported-languages'; import langs from '../../../../utils/supported-languages';
const propTypes = {
fields: PropTypes.object,
handleSubmit: PropTypes.func.isRequired,
updateMyLang: PropTypes.func.isRequired
};
const mapStateToProps = createSelector( const mapStateToProps = createSelector(
userSelector, userSelector,
({ user: { languageTag } }) => ({ ({ user: { languageTag } }) => ({
@ -14,7 +20,7 @@ const mapStateToProps = createSelector(
initialValues: languageTag ? { lang: languageTag } : null initialValues: languageTag ? { lang: languageTag } : null
}) })
); );
const actions = { updateMyLang }; const mapDispatchToProps = { updateMyLang };
const fields = [ 'lang' ]; const fields = [ 'lang' ];
const validator = values => { const validator = values => {
if (!langs[values.lang]) { if (!langs[values.lang]) {
@ -51,11 +57,6 @@ const options = [(
]; ];
export class LanguageSettings extends React.Component { export class LanguageSettings extends React.Component {
static propTypes = {
fields: PropTypes.object,
handleSubmit: PropTypes.func.isRequired,
updateMyLang: PropTypes.func.isRequired
};
constructor(...props) { constructor(...props) {
super(...props); super(...props);
this.handleChange = this.handleChange.bind(this); this.handleChange = this.handleChange.bind(this);
@ -80,16 +81,17 @@ export class LanguageSettings extends React.Component {
render() { render() {
const { const {
fields: { lang } fields: { lang: { name, value } }
} = this.props; } = this.props;
return ( return (
<FormGroup> <FormGroup>
<FormControl <FormControl
className='btn btn-block btn-primary btn-link-social btn-lg' className='btn btn-block btn-primary btn-link-social btn-lg'
componentClass='select' componentClass='select'
{ ...lang } name={ name }
onChange={ this.handleChange } onChange={ this.handleChange }
style={{ height: '45px' }} style={{ height: '45px' }}
value={ value }
> >
{ options } { options }
</FormControl> </FormControl>
@ -98,6 +100,8 @@ export class LanguageSettings extends React.Component {
} }
} }
LanguageSettings.propTypes = propTypes;
export default reduxForm( export default reduxForm(
{ {
form: 'lang', form: 'lang',
@ -106,5 +110,5 @@ export default reduxForm(
overwriteOnInitialValuesChange: false overwriteOnInitialValuesChange: false
}, },
mapStateToProps, mapStateToProps,
actions mapDispatchToProps
)(LanguageSettings); )(LanguageSettings);