From 0e82538dd3a17c802f1b1b39dc78b9a5224819a8 Mon Sep 17 00:00:00 2001 From: Sahat Yalkabov Date: Wed, 8 Jan 2014 00:41:56 -0500 Subject: [PATCH] Updated 404 page. Deleted 500 page. Switched to default Connect's expressHandler() that show stack trace. --- app.js | 6 +----- views/404.jade | 8 +++----- views/500.jade | 47 ----------------------------------------------- 3 files changed, 4 insertions(+), 57 deletions(-) delete mode 100644 views/500.jade diff --git a/app.js b/app.js index 71447c7f1c..65e4b6aeef 100755 --- a/app.js +++ b/app.js @@ -60,11 +60,7 @@ app.use(function(req, res) { res.status(404); res.render('404'); }); -app.use(function(err, req, res, next){ - console.error(err.stack); - res.status(500); - res.render('500'); -}); +app.use(express.errorHandler()); /** * Routes. diff --git a/views/404.jade b/views/404.jade index f2eceed8fa..76bc7ba4d1 100644 --- a/views/404.jade +++ b/views/404.jade @@ -17,8 +17,7 @@ html border-left-color: #999; border-bottom-color: #BBB; border-top: #8CC84B solid 4px; - border-top-left-radius: 9px; - border-top-right-radius: 9px; + border-radius: 9px; background-color: white; padding: 7px 4em 0 4em; } @@ -43,6 +42,5 @@ html } body .dialog - h1 The page you were looking for doesn't exist. - p You may have mistyped the address or the page may have moved. - p If you are the application owner check the logs for more information. + h1 404 Not Found + p The page you were looking for doesn't exist. diff --git a/views/500.jade b/views/500.jade deleted file mode 100644 index e117290875..0000000000 --- a/views/500.jade +++ /dev/null @@ -1,47 +0,0 @@ -doctype html -html - head - title We're sorry, but something went wrong (500) - style. - body { - background-color: #EFEFEF; - color: #2E2F30; - text-align: center; - font-family: arial, sans-serif; - } - div.dialog { - width: 25em; - margin: 4em auto 0 auto; - border: 1px solid #CCC; - border-right-color: #999; - border-left-color: #999; - border-bottom-color: #BBB; - border-top: #8CC84B solid 4px; - border-top-left-radius: 9px; - border-top-right-radius: 9px; - background-color: white; - padding: 7px 4em 0 4em; - } - h1 { - font-size: 100%; - color: #480; - line-height: 1.5em; - } - body > p { - width: 33em; - margin: 0 auto 1em; - padding: 1em 0; - background-color: #F7F7F7; - border: 1px solid #CCC; - border-right-color: #999; - border-bottom-color: #999; - border-bottom-left-radius: 4px; - border-bottom-right-radius: 4px; - border-top-color: #DADADA; - color: #666; - box-shadow:0 3px 8px rgba(50, 50, 50, 0.17); - } - body - .dialog - h1 We're sorry, but something went wrong. - p If you are the application owner check the logs for more information.