From 13c9d97262245b126d49d5269c233546bd8434cb Mon Sep 17 00:00:00 2001
From: Berkeley Martinez <BerkeleyTrue@users.noreply.github.com>
Date: Thu, 18 Jan 2018 21:33:57 -0800
Subject: [PATCH] fix(error-reporter): Only report uncaught errors (#16526)

Errors that have status codes do not need reporting. If opbeat is not enabled, do not report
---
 server/middlewares/error-reporter.js | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/server/middlewares/error-reporter.js b/server/middlewares/error-reporter.js
index d9651460bb..5b3aaba86b 100644
--- a/server/middlewares/error-reporter.js
+++ b/server/middlewares/error-reporter.js
@@ -8,7 +8,8 @@ import {
 
 const log = debug('fcc:middlewares:error-reporter');
 
-export default function errorHandler() {
+const isOpbeatDisabled = !opbeat.appId;
+export default function errrorReporter() {
   if (process.env.NODE_ENV !== 'production') {
     return (err, req, res, next) => {
       if (isHandledError(err)) {
@@ -22,7 +23,14 @@ export default function errorHandler() {
   return (err, req, res, next) => {
     // handled errors do not need to be reported
     // the report a message and redirect the user
-    if (isHandledError(err)) {
+    if (
+      isOpbeatDisabled ||
+      isHandledError(err) ||
+      // errors with status codes shouldn't be reported
+      // as they are usually user messages
+      err.statusCode ||
+      err.status
+    ) {
       return next(err);
     }
     return opbeat.captureError(err, { request: req }, () => next(err));