From 0365a6590a394d16348bb8646f6c033065f2644c Mon Sep 17 00:00:00 2001 From: Jay Hennessy Date: Tue, 26 May 2015 12:47:13 -0700 Subject: [PATCH 1/5] improved tests for chunky monkey bonfire --- seed_data/challenges/basic-bonfires.json | 1 + 1 file changed, 1 insertion(+) diff --git a/seed_data/challenges/basic-bonfires.json b/seed_data/challenges/basic-bonfires.json index b35ce5c45b..2f7d0d5deb 100644 --- a/seed_data/challenges/basic-bonfires.json +++ b/seed_data/challenges/basic-bonfires.json @@ -315,6 +315,7 @@ "tests": [ "assert.deepEqual(chunk(['a', 'b', 'c', 'd'], 2), [['a', 'b'], ['c', 'd']], 'should return chunked arrays');", "assert.deepEqual(chunk([0, 1, 2, 3, 4, 5], 3), [[0, 1, 2], [3, 4, 5]], 'should return chunked arrays');", + "assert.deepEqual(chunk([0, 1, 2, 3, 4, 5], 2), [[0, 1], [2, 3], [4, 5]], 'should return chunked arrays');", "assert.deepEqual(chunk([0, 1, 2, 3, 4, 5], 4), [[0, 1, 2, 3], [4, 5]], 'should return the last chunk as remaining elements');" ], "MDNlinks": ["Array.push()"], From 02e5ada30481b2b57ea11844ba645831124b520b Mon Sep 17 00:00:00 2001 From: Doug Shamoo Date: Wed, 27 May 2015 14:03:06 +0800 Subject: [PATCH 2/5] very minor grammatical error fixed --- seed_data/challenges/bootstrap.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed_data/challenges/bootstrap.json b/seed_data/challenges/bootstrap.json index 1db7d227aa..34ff79e3ae 100644 --- a/seed_data/challenges/bootstrap.json +++ b/seed_data/challenges/bootstrap.json @@ -1090,7 +1090,7 @@ "name": "Waypoint: Style Text Inputs as Form Controls", "difficulty" : 0.061, "description": [ - "Give your form's text input field in a class of \"form-control\". Give your form's submit button the classes \"btn btn-primary\" and give it the Font Awesome icon of \"fa-paper-plane\"." + "Give your form's text input field a class of \"form-control\". Give your form's submit button the classes \"btn btn-primary\" and give it the Font Awesome icon of \"fa-paper-plane\"." ], "tests": [ "assert($('.btn-primary').length > 1, 'Give the submit button in your form the classes \"btn btn-primary\".')", From e5e2dec017c209bbd660d80e67bec841a4d3c25a Mon Sep 17 00:00:00 2001 From: Doug Shamoo Date: Wed, 27 May 2015 15:26:04 +0800 Subject: [PATCH 3/5] Issue 569 fix, tests added. --- seed_data/challenges/basic-html5-and-css.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/seed_data/challenges/basic-html5-and-css.json b/seed_data/challenges/basic-html5-and-css.json index cb2ab71f61..271a5f9cc5 100644 --- a/seed_data/challenges/basic-html5-and-css.json +++ b/seed_data/challenges/basic-html5-and-css.json @@ -1936,8 +1936,10 @@ "You can also use this notation for margins!" ], "tests": [ - "assert($('.green-box').css('padding-left') === '40px', 'Your green-box class should give the left of elements 40px of padding.')", - "assert($('.green-box').css('padding-bottom') === '20px', 'Your green-box class should give the bottom of elements 20px of padding.')" + "assert($('.green-box').css('padding-top') === '40px', 'Your green-box class should give the top of elements 40px of padding.')", + "assert($('.green-box').css('padding-right') === '20px', 'Your green-box class should give the right of elements 20px of padding.')", + "assert($('.green-box').css('padding-bottom') === '20px', 'Your green-box class should give the bottom of elements 20px of padding.')", + "assert($('.green-box').css('padding-left') === '40px', 'Your green-box class should give the left of elements 40px of padding.')" ], "challengeSeed": [ "