gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor: drop superorder from metas (#44422)

Browse Source 
* refactor: create superOrder from superblock

* chore: drop superOrders from meta

* fix: return null for 'certifications'

* fix: only set superOrder if it is needed

* fix(tests): remove filter from order tests

* test: use getSuperOrder, since superOrder has gone

* test: ignore certificates

* fix: getSuperOrder throw for 'certifications'

* test: remove certificate special case

It wasn't necessary, anyway (it had never been working because I put
certificate not certification)

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
This commit is contained in:
Oliver Eyton-Williams
2021-12-14 17:16:23 +01:00
committed by GitHub
parent d4f490419f
commit 1642c631de
74 changed files with 81 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
curriculum/getChallenges.js
View File

@ -4,6 +4,7 @@ const util = require('util');
const yaml = require('js-yaml');
const { findIndex } = require('lodash');
const readDirP = require('readdirp');
const { getSuperOrder } = require('./utils');
const { helpCategoryMap } = require('../client/utils/challenge-types');
const { showUpcomingChanges } = require('../config/env.json');
const { curriculum: curriculumLangs } =
@ -296,7 +297,6 @@ ${getFullPath('english')}
const {
name: blockName,
order,
superOrder,
isPrivate,
required = [],
template,
@ -305,7 +305,8 @@ ${getFullPath('english')}
} = meta;
challenge.block = dasherize(blockName);
challenge.order = order;
challenge.superOrder = superOrder;
const superOrder = getSuperOrder(superBlock);
if (superOrder !== null) challenge.superOrder = superOrder;
challenge.superBlock = superBlock;
challenge.challengeOrder = challengeOrder;
challenge.isPrivate = challenge.isPrivate || isPrivate;