gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: translatable "code saved" message (#45130)

Browse Source
This commit is contained in:
Naomi Carrigan
2022-02-17 08:03:02 -08:00
committed by GitHub
parent 4d57eae187
commit 1681cf262a
4 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/i18n/locales/english/translations.json
View File

@@ -523,7 +523,9 @@
"delete-token-err": "An error occurred trying to delete your token", "delete-token-err": "An error occurred trying to delete your token",
"token-created": "You have successfully created a new token.", "token-created": "You have successfully created a new token.",
"token-deleted": "Your token has been deleted.", "token-deleted": "Your token has been deleted.",
"complete-project-first": "You must complete the project first." "complete-project-first": "You must complete the project first.",
"local-code-save-error": "Oops, your code did not save, your browser's local storage may be full.",
"local-code-saved": "Saved! Your code was saved to your browser's local storage."
}, },
"validation": { "validation": {
"max-characters": "There is a maximum limit of 288 characters, you have {{charsLeft}} left", "max-characters": "There is a maximum limit of 288 characters, you have {{charsLeft}} left",

2
client/src/components/Flash/redux/flash-messages.ts
View File

@@ -11,6 +11,8 @@ export enum FlashMessages {
EmailValid = 'flash.email-valid', EmailValid = 'flash.email-valid',
HonestFirst = 'flash.honest-first', HonestFirst = 'flash.honest-first',
IncompleteSteps = 'flash.incomplete-steps', IncompleteSteps = 'flash.incomplete-steps',
LocalCodeSaved = 'flash.local-code-saved',
LocalCodeSaveError = 'flash.local-code-save-error',
NameNeeded = 'flash.name-needed', NameNeeded = 'flash.name-needed',
None = '', None = '',
NotEligible = 'flash.not-eligible', NotEligible = 'flash.not-eligible',

5
client/src/templates/Challenges/redux/code-storage-epic.js
View File

@@ -5,6 +5,7 @@ import store from 'store';
import { setContent, isPoly } from '../../../../../utils/polyvinyl'; import { setContent, isPoly } from '../../../../../utils/polyvinyl';
import { createFlashMessage } from '../../../components/Flash/redux'; import { createFlashMessage } from '../../../components/Flash/redux';
import { FlashMessages } from '../../../components/Flash/redux/flash-messages';
import { actionTypes as appTypes } from '../../../redux/action-types'; import { actionTypes as appTypes } from '../../../redux/action-types';
import { actionTypes } from './action-types'; import { actionTypes } from './action-types';
@@ -112,8 +113,8 @@ function saveCodeEpic(action$, state$) {
createFlashMessage({ createFlashMessage({
type: error ? 'warning' : 'success', type: error ? 'warning' : 'success',
message: error message: error
? "Oops, your code did not save, your browser's local storage may be full." ? FlashMessages.LocalCodeSaveError
: "Saved! Your code was saved to your browser's local storage." : FlashMessages.LocalCodeSaved
}) })
) )
) )

2
client/src/utils/tone/index.ts
View File

@@ -26,6 +26,8 @@ const toneUrls = {
[FlashMessages.EmailValid]: CHAL_COMP, [FlashMessages.EmailValid]: CHAL_COMP,
[FlashMessages.HonestFirst]: TRY_AGAIN, [FlashMessages.HonestFirst]: TRY_AGAIN,
[FlashMessages.IncompleteSteps]: TRY_AGAIN, [FlashMessages.IncompleteSteps]: TRY_AGAIN,
[FlashMessages.LocalCodeSaved]: CHAL_COMP,
[FlashMessages.LocalCodeSaveError]: TRY_AGAIN,
[FlashMessages.NameNeeded]: TRY_AGAIN, [FlashMessages.NameNeeded]: TRY_AGAIN,
// [FlashMessages.None]: '', // [FlashMessages.None]: '',
[FlashMessages.NotEligible]: TRY_AGAIN, [FlashMessages.NotEligible]: TRY_AGAIN,