gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix add to completed challenges on cert verify

Browse Source
This commit is contained in:
Berkeley Martinez
2015-10-05 19:58:44 -07:00
parent bf4ccab586
commit 202d0fa068
2 changed files with 30 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
server/boot/certificate.js
View File

@ -13,8 +13,11 @@ import {
observeQuery observeQuery
} from '../utils/rx'; } from '../utils/rx';
const frontEndChallangeId = '561add10cb82ac38a17513be'; import {
const fullStackChallangeId = '660add10cb82ac38a17513be'; frontEndChallangeId,
fullStackChallangeId
} from '../utils/constantStrings.json';
const debug = debugFactory('freecc:certification'); const debug = debugFactory('freecc:certification');
const sendMessageToNonUser = ifNoUserSend( const sendMessageToNonUser = ifNoUserSend(
'must be logged in to complete.' 'must be logged in to complete.'
@ -36,10 +39,12 @@ export default function certificate(app) {
'findById', 'findById',
frontEndChallangeId, frontEndChallangeId,
{ {
tests: true id: true,
tests: true,
name: true,
challengeType: true
} }
) )
.map(({ tests = [] }) => tests)
.shareReplay(); .shareReplay();
const fullStackChallangeIds$ = observeQuery( const fullStackChallangeIds$ = observeQuery(
@ -47,10 +52,12 @@ export default function certificate(app) {
'findById', 'findById',
fullStackChallangeId, fullStackChallangeId,
{ {
tests: true id: true,
tests: true,
name: true,
challengeType: true
} }
) )
.map(({ tests = [] }) => tests)
.shareReplay(); .shareReplay();
router.post( router.post(
@ -82,8 +89,14 @@ export default function certificate(app) {
} }
return fullStackChallangeIds$; return fullStackChallangeIds$;
}) })
.flatMap((tests) => { .flatMap(challenge => {
const { user } = req; const { user } = req;
const {
id,
tests,
name,
challengeType
} = challenge;
if ( if (
isFront && !user.isFrontEndCert && isCertified(tests, user) || isFront && !user.isFrontEndCert && isCertified(tests, user) ||
!isFront && !user.isFullStackCert && isCertified(tests, user) !isFront && !user.isFullStackCert && isCertified(tests, user)
@ -91,17 +104,16 @@ export default function certificate(app) {
debug('certified'); debug('certified');
if (isFront) { if (isFront) {
user.isFrontEndCert = true; user.isFrontEndCert = true;
user.completedChallenges.push({
completedDate: new Date(),
id: frontEndChallangeId
})
} else { } else {
user.isFullStackCert = true; user.isFullStackCert = true;
user.completedChallenges.push({
completedDate: new Date(),
id: fullStackChallangeId
})
} }
user.completedChallenges.push({
id,
name,
completedDate: new Date(),
challengeType
});
return saveUser(user); return saveUser(user);
} }
return Observable.just(user); return Observable.just(user);

4
server/utils/constantStrings.json
View File

@ -1,3 +1,5 @@
{ {
"gitHubUserAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1521.3 Safari/537.36" "gitHubUserAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1521.3 Safari/537.36",
"frontEndChallangeId": "561add10cb82ac38a17513be",
"fullStackChallangeId": "660add10cb82ac38a17513be"
} }