fix: stop modal appearing in steps (#43728)

* fix: stop showing completion modal on steps

* feat: submit steps with ctrl+enter

* fix: handle ctrl+enter when not focussing editor

* fix: reset tests when user types

* refactor: pass showCompletionModal as an option

Otherwise we have to write executeChallenge(true) which does not mean
what you might reasonably expect.

* fix: always executeChallenge when not on step

* fix: update frontend project show

* fix: handle missing payload

* refactor: isProjectStep -> hasEditableRegion

* refactor: more renaming

* fix: make meta.json control multifile editor use

* fix: update the challengeSchema correctly

* Update client/src/templates/Challenges/classic/editor.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: remove logging

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
This commit is contained in:
Oliver Eyton-Williams
2021-10-13 13:47:59 +02:00
committed by GitHub
parent 9220bfedad
commit 22afdd1aad
24 changed files with 149 additions and 45 deletions

View File

@ -1,6 +1,7 @@
{
"name": "Accessibility Quiz",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "accessibility-quiz",
"order": 42,
"time": "5 hours",
@ -279,4 +280,4 @@
"Part 67"
]
]
}
}

View File

@ -1,6 +1,7 @@
{
"name": "Basic CSS Cafe Menu",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "basic-css-cafe-menu",
"order": 10,
"time": "5 hours",

View File

@ -1,6 +1,7 @@
{
"name": "Basic HTML Cat Photo App",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "basic-html-cat-photo-app",
"order": 9,
"time": "5 hours",

View File

@ -1,6 +1,7 @@
{
"name": "Basic JavaScript RPG Game",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "basic-javascript-rpg-game",
"order": 11,
"time": "2 hours",

View File

@ -1,6 +1,7 @@
{
"name": "CSS Box Model",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "css-box-model",
"order": 12,
"time": "5 hours",

View File

@ -1,6 +1,7 @@
{
"name": "CSS Piano",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "css-piano",
"order": 13,
"time": "5 hours",

View File

@ -1,6 +1,7 @@
{
"name": "CSS Picasso Painting",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "css-picasso-painting",
"order": 11,
"time": "5 hours",
@ -367,4 +368,4 @@
"Part 89"
]
]
}
}

View File

@ -1,6 +1,7 @@
{
"name": "CSS Variables Skyline",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "css-variables-skyline",
"order": 8,
"time": "5 hours",

View File

@ -1,6 +1,7 @@
{
"name": "D3 Dashboard",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "d3-dashboard",
"order": 4,
"time": "5 hours",

View File

@ -1,6 +1,7 @@
{
"name": "Functional Programming Spreadsheet",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "functional-programming-spreadsheet",
"order": 13,
"time": "2 hours",

View File

@ -1,6 +1,7 @@
{
"name": "Intermediate JavaScript Calorie Counter",
"isUpcomingChange": true,
"usesMultifileEditor": true,
"dashedName": "intermediate-javascript-calorie-counter",
"order": 12,
"time": "2 hours",