gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixes small bugs

Browse Source 
+ With MDNLinks and bonfireExecute being run on step challenges.
+ Return when common isn't loaded in reBindModals instead of throwing.
This commit is contained in:
Logan Tegman
2015-11-07 12:54:58 -08:00
parent 2ed6143c68
commit 2667b574bf
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
client/main.js
View File

@ -252,7 +252,7 @@ $(document).ready(function() {
function reBindModals() { function reBindModals() {
if (!window.common) { if (!window.common) {
throw new Error('common framework should be loaded.'); return;
} }
var common = window.common; var common = window.common;

2
server/views/coursewares/showBonfire.jade
View File

@ -135,6 +135,6 @@ block content
} }
}); });
if (!{JSON.stringify(MDNlinks.length)}) { if (!!{JSON.stringify(MDNlinks.length)}) {
$('#MDN-links').addClass('collapse'); $('#MDN-links').addClass('collapse');
} }

2
server/views/coursewares/showJS.jade
View File

@ -101,7 +101,7 @@ block content
include ../partials/challenge-footer include ../partials/challenge-footer
script. script.
if (!{JSON.stringify(MDNlinks.length)}) { if (!!{JSON.stringify(MDNlinks.length)}) {
$('#MDN-links').addClass('collapse'); $('#MDN-links').addClass('collapse');
} }
document.addEventListener('gitter-sidecar-ready', function(e) { document.addEventListener('gitter-sidecar-ready', function(e) {

2
server/views/coursewares/showStep.jade
View File

@ -39,7 +39,7 @@ block content
common.challengeId = !{JSON.stringify(challengeId)}; common.challengeId = !{JSON.stringify(challengeId)};
common.challengeName = !{JSON.stringify(name)}; common.challengeName = !{JSON.stringify(name)};
common.challengeType = 7; common.challengeType = !{JSON.stringify(challengeType)};
common.dashedName = !{JSON.stringify(dashedName || '')}; common.dashedName = !{JSON.stringify(dashedName || '')};
common.isHonest = !{JSON.stringify(isHonest || false)}; common.isHonest = !{JSON.stringify(isHonest || false)};
common.isFrontEndCert = !{JSON.stringify(isFrontEndCert || false)}; common.isFrontEndCert = !{JSON.stringify(isFrontEndCert || false)};