From 26bb9a4e218de89325f62a1c9865c12b359f0e9f Mon Sep 17 00:00:00 2001 From: Ahmad Abdolsaheb Date: Mon, 7 Dec 2020 16:35:28 +0300 Subject: [PATCH] feat: isolate donation views (#40383) * feat: capitalize all donation cats * feat: isolate donation page views from donation actions --- client/src/client-only-routes/ShowCertification.js | 4 ++-- client/src/components/Donation/DonationModal.js | 4 ++-- client/src/pages/donate.js | 4 ++-- client/src/redux/ga-saga.test.js | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/client/src/client-only-routes/ShowCertification.js b/client/src/client-only-routes/ShowCertification.js index 1d471d8f5a..5b3ba2b93c 100644 --- a/client/src/client-only-routes/ShowCertification.js +++ b/client/src/client-only-routes/ShowCertification.js @@ -117,7 +117,7 @@ const ShowCertification = props => { executeGA({ type: 'event', data: { - category: 'Donation', + category: 'Donation View', action: 'Displayed Certificate Donation', nonInteraction: true } @@ -138,7 +138,7 @@ const ShowCertification = props => { props.executeGA({ type: 'event', data: { - category: 'donation', + category: 'Donation', action: `certificate ${action}`, label: duration, value: amount diff --git a/client/src/components/Donation/DonationModal.js b/client/src/components/Donation/DonationModal.js index aa3e9412b6..6b7751f3f2 100644 --- a/client/src/components/Donation/DonationModal.js +++ b/client/src/components/Donation/DonationModal.js @@ -68,7 +68,7 @@ function DonateModal({ executeGA({ type: 'event', data: { - category: 'donation', + category: 'Donation', action: `Modal ${action}`, label: duration, value: amount @@ -83,7 +83,7 @@ function DonateModal({ executeGA({ type: 'event', data: { - category: 'Donation', + category: 'Donation View', action: `Displayed ${ isBlockDonation ? 'block' : 'progress' } donation modal`, diff --git a/client/src/pages/donate.js b/client/src/pages/donate.js index bcf805c1a4..f4dcb5798b 100644 --- a/client/src/pages/donate.js +++ b/client/src/pages/donate.js @@ -49,7 +49,7 @@ export class DonatePage extends Component { this.props.executeGA({ type: 'event', data: { - category: 'Donation', + category: 'Donation View', action: `Displayed donate page`, nonInteraction: true } @@ -60,7 +60,7 @@ export class DonatePage extends Component { this.props.executeGA({ type: 'event', data: { - category: 'donation', + category: 'Donation', action: `donate page ${action}`, label: duration, value: amount diff --git a/client/src/redux/ga-saga.test.js b/client/src/redux/ga-saga.test.js index 2c3401fec5..08f39b8d03 100644 --- a/client/src/redux/ga-saga.test.js +++ b/client/src/redux/ga-saga.test.js @@ -9,7 +9,7 @@ describe('ga-saga', () => { const mockEventPayload = { type: 'event', data: { - category: 'donation', + category: 'Donation', action: 'year end gift paypal button click' } };