From d80ed9f366aa158fb3f45a16e7468215f16bcc6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Djordje=20Lacmanovi=C4=87?= Date: Sun, 16 Aug 2015 00:37:31 +0200 Subject: [PATCH 01/33] fixes issue #1005 --- seed/challenges/html5-and-css.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/html5-and-css.json b/seed/challenges/html5-and-css.json index 7cbb0d11c7..506ee7f30c 100644 --- a/seed/challenges/html5-and-css.json +++ b/seed/challenges/html5-and-css.json @@ -483,7 +483,7 @@ "description": [ "Apply the \"red-text\" class to your h2 and p elements.", "Remember that you can attach classes to HTML elements by using class=\"your-class-here\" within the relevant element's opening tag.", - "Remember that CSS selectors require a period at the beginning like this: .blue-text { color: blue; }, but that class declarations don't use a period, like this: <h2 class=\"blue-text\">CatPhotoApp<h2>." + "Remember that CSS class selectors require a period at the beginning like this: .blue-text { color: blue; }, but that class declarations don't use a period, like this: <h2 class=\"blue-text\">CatPhotoApp<h2>." ], "tests": [ "assert($('h2').css('color') === 'rgb(255, 0, 0)', 'Your h2 element should be red.')", From 1790b14808af637469b498d0a0ae88133df469e8 Mon Sep 17 00:00:00 2001 From: Aryan Jabbari Date: Sun, 16 Aug 2015 20:06:47 -0400 Subject: [PATCH 02/33] Fixes #1801 --- seed/challenges/basic-javascript.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/seed/challenges/basic-javascript.json b/seed/challenges/basic-javascript.json index fa59afe650..9b3944f236 100644 --- a/seed/challenges/basic-javascript.json +++ b/seed/challenges/basic-javascript.json @@ -726,10 +726,10 @@ ], "challengeSeed":[ "//var ourDog = {", - "// \"name\": \"Camper\"", - "// \"legs\": 4", - "// \"tails\": 1", - "// \"friends\": [\"everything!\"]", + "// \"name\": \"Camper\",", + "// \"legs\": 4,", + "// \"tails\": 1,", + "// \"friends\": [\"everything!\"],", "//};", "", "// add the name(string), legs(number), tails(number) and friends(array) properties to myDog.", @@ -766,10 +766,10 @@ ], "challengeSeed":[ "// var ourDog = {", - "// \"name\": \"Camper\"", - "// \"legs\": 4", - "// \"tails\": 1", - "// \"friends\": [\"everything!\"]", + "// \"name\": \"Camper\",", + "// \"legs\": 4,", + "// \"tails\": 1,", + "// \"friends\": [\"everything!\"],", "// };", "", "// ourDog.bark(\"arf!\");", From ae4ec8e9fd443260ffce6c99ebc893fbc40de162 Mon Sep 17 00:00:00 2001 From: Aryan Jabbari Date: Sun, 16 Aug 2015 20:08:37 -0400 Subject: [PATCH 03/33] Deleted extra comma --- seed/challenges/basic-javascript.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/seed/challenges/basic-javascript.json b/seed/challenges/basic-javascript.json index 9b3944f236..75fde692ad 100644 --- a/seed/challenges/basic-javascript.json +++ b/seed/challenges/basic-javascript.json @@ -729,7 +729,7 @@ "// \"name\": \"Camper\",", "// \"legs\": 4,", "// \"tails\": 1,", - "// \"friends\": [\"everything!\"],", + "// \"friends\": [\"everything!\"]", "//};", "", "// add the name(string), legs(number), tails(number) and friends(array) properties to myDog.", @@ -769,7 +769,7 @@ "// \"name\": \"Camper\",", "// \"legs\": 4,", "// \"tails\": 1,", - "// \"friends\": [\"everything!\"],", + "// \"friends\": [\"everything!\"]", "// };", "", "// ourDog.bark(\"arf!\");", From 854406e5fad736dc8ff79aebe2a2780cca22b939 Mon Sep 17 00:00:00 2001 From: Aryan Jabbari Date: Sun, 16 Aug 2015 20:14:12 -0400 Subject: [PATCH 04/33] Fixes #1807 --- seed/challenges/basic-javascript.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/basic-javascript.json b/seed/challenges/basic-javascript.json index fa59afe650..048a99f311 100644 --- a/seed/challenges/basic-javascript.json +++ b/seed/challenges/basic-javascript.json @@ -992,7 +992,7 @@ "title": "Sift through Text with Regular Expressions", "difficulty":"9.984", "description":[ - "Regular expressions are way to find certain words or patterns inside of strings.", + "Regular expressions are used to find certain words or patterns inside of strings.", "For example, if we wanted to find the number of times the word the occurred in the string The dog chased the cat, we could use the following regular expression: \/the+\/gi", "Let's break this down a bit:", "the is the pattern we want to match.", From e4e13cf676196e14172ca7a4cdc6517732ad3f18 Mon Sep 17 00:00:00 2001 From: Aryan Jabbari Date: Sun, 16 Aug 2015 20:38:49 -0400 Subject: [PATCH 05/33] Fixed issue #1806 --- seed/challenges/advanced-bonfires.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/advanced-bonfires.json b/seed/challenges/advanced-bonfires.json index f71370c238..62a5f2cd3c 100644 --- a/seed/challenges/advanced-bonfires.json +++ b/seed/challenges/advanced-bonfires.json @@ -80,7 +80,7 @@ "sym([1, 2, 3], [5, 2, 1, 4]);" ], "tests": [ - "expect(sym([1, 2, 3], [5, 2, 1, 4])).to.equal([3, 5, 4]);", + "assert.deepEqual(sym([1, 2, 3], [5, 2, 1, 4]), [3, 5, 4], 'should return an array of unique values');", "assert.deepEqual(sym([1, 2, 5], [2, 3, 5], [3, 4, 5]), [1, 4, 5], 'should return the symmetric difference of the given arrays');", "assert.deepEqual(sym([1, 1, 2, 5], [2, 2, 3, 5], [3, 4, 5, 5]), [1, 4, 5], 'should return an array of unique values');", "assert.deepEqual(sym([1, 1]), [1], 'should return an array of unique values');" From fda754f187605f28f7d860cdac8e406d8864f4f6 Mon Sep 17 00:00:00 2001 From: Aryan Jabbari Date: Sun, 16 Aug 2015 20:47:43 -0400 Subject: [PATCH 06/33] Fixed #1813 --- seed/challenges/basic-javascript.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/basic-javascript.json b/seed/challenges/basic-javascript.json index fa59afe650..a62a77a5ed 100644 --- a/seed/challenges/basic-javascript.json +++ b/seed/challenges/basic-javascript.json @@ -902,7 +902,7 @@ ], "challengeSeed":[ "function myFunction(){", - " // Make myFunction return a random number between zero and nine instead of a decimal", + " // Make myFunction return a random number between 'min' and 'max' instead of a decimal", "", " // Only change code below this line.", "", From 1be07e73c118cd60f7189e0a89d71e24bd4c7ab7 Mon Sep 17 00:00:00 2001 From: Michael Krebs Date: Sun, 16 Aug 2015 20:59:17 -0400 Subject: [PATCH 07/33] fix #935 --- seed/challenges/intermediate-bonfires.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/seed/challenges/intermediate-bonfires.json b/seed/challenges/intermediate-bonfires.json index 10c1c35bcf..e4811bcb1c 100644 --- a/seed/challenges/intermediate-bonfires.json +++ b/seed/challenges/intermediate-bonfires.json @@ -71,10 +71,10 @@ ], "MDNlinks": [ "Comparison Operators", - "String.slice()", + "Array.slice()", "Array.filter()", "Array.indexOf()", - "String.concat()" + "Array.concat()" ], "type": "bonfire", "challengeType": 5, From af22c6c6abb324b3524aa0fa5da831ff80c9acb9 Mon Sep 17 00:00:00 2001 From: Aryan Jabbari Date: Sun, 16 Aug 2015 21:27:22 -0400 Subject: [PATCH 08/33] Fixed #1820 --- seed/challenges/html5-and-css.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/seed/challenges/html5-and-css.json b/seed/challenges/html5-and-css.json index 4d4ae95cad..926676c9e4 100644 --- a/seed/challenges/html5-and-css.json +++ b/seed/challenges/html5-and-css.json @@ -3681,8 +3681,8 @@ "Make the body element's background color a dark gray by giving it the hex code value of #111111." ], "tests": [ - "assert($(\"body\").css(\"background-color\") === \"rgb(17, 17, 17)\", 'Give your body element the background-color of a light gray.')", - "assert(editor.match(/#111111/g) && editor.match(/#111111/g).length > 0, 'Use hex code to make a light gray. For example body { color: #111111; }.')" + "assert($(\"body\").css(\"background-color\") === \"rgb(17, 17, 17)\", 'Give your body element the background-color of a dark gray.')", + "assert(editor.match(/#111111/g) && editor.match(/#111111/g).length > 0, 'Use hex code to make a dark gray. For example body { color: #111111; }.')" ], "challengeSeed": [ "