From 4dcaac8bc58bab9057f6e08ab28c2a39b8086655 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Thu, 28 May 2015 06:51:17 -0400 Subject: [PATCH 01/17] Specifies to add a solid border, closes #694 --- seed_data/challenges/basic-html5-and-css.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed_data/challenges/basic-html5-and-css.json b/seed_data/challenges/basic-html5-and-css.json index e1e4a582dc..bb8c5bd7aa 100644 --- a/seed_data/challenges/basic-html5-and-css.json +++ b/seed_data/challenges/basic-html5-and-css.json @@ -734,7 +734,7 @@ "name": "Waypoint: Add Borders Around your Elements", "difficulty": 0.028, "description": [ - "Create a class called \"thick-green-border\" that puts a 10-pixel-wide green border around an HTML element, and apply it to your cat photo.", + "Create a class called \"thick-green-border\" that puts a 10-pixel-wide green border with a style of \"solid\" around an HTML element, and apply it to your cat photo.", "CSS borders have attributes like style, color and width.", "For example, if we wanted to create a red, 5 pixel border around an HTML element, we could use this class: <style> .thin-red-border { border-color: red; border-width: 5px; border-style: solid; } </style>." ], From e3fff3808e2cbcfe59345a9c78579f6b92cf9227 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Thu, 28 May 2015 06:55:03 -0400 Subject: [PATCH 02/17] Linkifies image in custom heading challenge, closes #693 --- seed_data/challenges/bootstrap.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed_data/challenges/bootstrap.json b/seed_data/challenges/bootstrap.json index a0f662ffb2..67076c6aa8 100644 --- a/seed_data/challenges/bootstrap.json +++ b/seed_data/challenges/bootstrap.json @@ -792,7 +792,7 @@ "We will make a simple heading for our Cat Photo App by putting them in the same row.", "Remember, Bootstrap uses a responsive grid system, which makes it easy to put elements into rows and specify each element's relative width. Most of Bootstrap's classes can be applied to a div element.", "Here's a diagram of how Bootstrap's 12-column grid layout works:", - "", + "", "Note that in this illustration, we use the col-md-* class. Here, \"md\" means \"medium\", and \"*\" is a number specifying how many columns wide the element should be. In this case, we're specifying how many columns wide an element should be on a medium-sized screen, such as a laptop.", "In the Cat Photo App that we're building, we'll use col-xs-*, where \"*\" is the number of columns wide the element should be, and \"xs\" means \"extra small\", like an extra-small mobile phone screen.", "Notice how the image is now just the right size to fit along the text?" From 268f58505075225d4d2953ccd1ebaf132ddd99c8 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Thu, 28 May 2015 06:59:11 -0400 Subject: [PATCH 03/17] References correct expressworks challenges, closes #692 --- seed_data/challenges/full-stack-javascript.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/seed_data/challenges/full-stack-javascript.json b/seed_data/challenges/full-stack-javascript.json index fb9c17ec68..c0c564827e 100644 --- a/seed_data/challenges/full-stack-javascript.json +++ b/seed_data/challenges/full-stack-javascript.json @@ -285,11 +285,11 @@ "Note that you can resize the c9.io's windows by dragging their borders.", "Make sure that you are always in your project's \"workspace\" directory. You can always navigate back to this directory by running this command: cd ~/workspace.", "Complete \"Hello World\"", - "Complete \"Juggling Async\"", - "Complete \"Time Server\"", - "Complete \"HTTP Collect\"", - "Complete \"Juggling Async\"", - "Complete \"Time Server\"", + "Complete \"Jade\"", + "Complete \"Good Old Form\"", + "Complete \"Stylish CSS\"", + "Complete \"Session and Cookie\"", + "Complete \"JSON Me\"", "Once you've completed these challenges, move on to our next waypoint." ], "challengeType": 2, From 119060dc3f8df694bd2ee5214a3fb590fc6210d6 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Thu, 28 May 2015 07:07:18 -0400 Subject: [PATCH 04/17] Reorder tests to display in clockwise notation, fixes typos in tests to match condition, closes #665 --- seed_data/challenges/basic-html5-and-css.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/seed_data/challenges/basic-html5-and-css.json b/seed_data/challenges/basic-html5-and-css.json index bb8c5bd7aa..dcdb7af127 100644 --- a/seed_data/challenges/basic-html5-and-css.json +++ b/seed_data/challenges/basic-html5-and-css.json @@ -2420,10 +2420,10 @@ "You can also use this notation for margins!" ], "tests": [ - "assert($('.green-box').css('margin-left') === '40px', 'Your green-box class should give the left of elements 40px of margin.')", + "assert($('.green-box').css('margin-top') === '40px', 'Your green-box class should give the top of elements 40px of margin.')", + "assert($('.green-box').css('margin-right') === '20px', 'Your green-box class should give the right of elements 20px of margin.')", "assert($('.green-box').css('margin-bottom') === '20px', 'Your green-box class should give the bottom of elements 20px of margin.')", - "assert($('.green-box').css('margin-top') === '40px', 'Your green-box class should give the top of elements 20px of margin.')", - "assert($('.green-box').css('margin-right') === '20px', 'Your green-box class should give the right of elements 20px of margin.')" + "assert($('.green-box').css('margin-left') === '40px', 'Your green-box class should give the left of elements 40px of margin.')" ], "challengeSeed": [ From f6cebdea2755768d20731f281517980c9fc08bae Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Thu, 28 May 2015 07:20:50 -0400 Subject: [PATCH 05/17] Tests correct tag for presence of href attribute set to '#', closes # 686 --- seed_data/challenges/basic-html5-and-css.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/seed_data/challenges/basic-html5-and-css.json b/seed_data/challenges/basic-html5-and-css.json index dcdb7af127..79d5d1e8ba 100644 --- a/seed_data/challenges/basic-html5-and-css.json +++ b/seed_data/challenges/basic-html5-and-css.json @@ -1099,7 +1099,8 @@ "Once you've done this, hover over your image with your cursor. Your cursor's normal pointer should become the link clicking pointer. The photo is now a link." ], "tests": [ - "expect($('a').children('img').length, 'Wrap your image element inside an anchor element that has its href attribute set to \"#\"').to.equal(1);" + "expect($('a').children('img').length, 'Wrap your image element inside an anchor element that has its href attribute set to \"#\"').to.equal(1);", + "expect(new RegExp('#').test($('a').children('img').parent().attr('href')), 'Make sure to specify the \"src\" attritube as \"#\"').to.be.true;" ], "challengeSeed": [ "", From 718ae04f2fe6865a1aa3d7ad7bd626f0f5663f95 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Thu, 28 May 2015 08:26:25 -0400 Subject: [PATCH 06/17] Add ability to test editor contents. Ensures classes are implemented, closes # 684 --- .../coursewaresHCJQFramework_0.1.5.js | 13 ++++-------- .../js/lib/coursewares/iFrameScripts_0.0.2.js | 19 ------------------ .../js/lib/coursewares/iFrameScripts_0.0.3.js | 20 +++++++++++++++++++ seed_data/challenges/basic-html5-and-css.json | 3 +++ 4 files changed, 27 insertions(+), 28 deletions(-) delete mode 100644 public/js/lib/coursewares/iFrameScripts_0.0.2.js create mode 100644 public/js/lib/coursewares/iFrameScripts_0.0.3.js diff --git a/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.5.js b/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.5.js index f38739c15a..050a9fbc54 100644 --- a/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.5.js +++ b/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.5.js @@ -49,14 +49,9 @@ var libraryIncludes = "