From f15d7daa2ed5e354f882c855489ca31331d359ff Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Tue, 26 May 2015 08:32:17 -0400 Subject: [PATCH 01/14] Fix for old challenge names in account view so linking still works. --- controllers/challenge.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/controllers/challenge.js b/controllers/challenge.js index 38d05e6bf6..c647feba67 100644 --- a/controllers/challenge.js +++ b/controllers/challenge.js @@ -147,10 +147,12 @@ exports.returnCurrentChallenge = function(req, res, next) { exports.returnIndividualChallenge = function(req, res, next) { var dashedName = req.params.challengeName; - var challengeName = dashedName.replace(/\-/g, ' ') - .split(' ') - .slice(1) - .join(' '); + var challengeName = /^(bonfire|waypoint)/.test(dashedName) ? dashedName + .replace(/\-/g, ' ') + .split(' ') + .slice(1) + .join(' ') + : dashedName; Challenge.find({'name': new RegExp(challengeName, 'i')}, function(err, challengeFromMongo) { From 9e9e28dc573ae098f7437ef87cd65f0a718b7da6 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Tue, 26 May 2015 08:34:38 -0400 Subject: [PATCH 02/14] Don't relative link to zipline and basejump solutions. --- views/account/show.jade | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/views/account/show.jade b/views/account/show.jade index c3255edd26..b4887d84d4 100644 --- a/views/account/show.jade +++ b/views/account/show.jade @@ -150,7 +150,7 @@ block content td.col-xs-4= challenge.name td.col-xs-2= moment(challenge.completedDate, 'x').format("MMM DD, YYYY") td.col-xs-6 - a(href=challenge.solution, target='_blank') View my solution + a(href="http://" + challenge.solution, target='_blank') View my solution br - if (bonfires.length > 0) From 8607a9b551414f2bdebec57cc4ef84fe1588b859 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Tue, 26 May 2015 08:40:22 -0400 Subject: [PATCH 03/14] rename drop it like its hot bonfire, closes #507 --- seed_data/challenges/basic-bonfires.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed_data/challenges/basic-bonfires.json b/seed_data/challenges/basic-bonfires.json index 907fc7af9b..347421d44e 100644 --- a/seed_data/challenges/basic-bonfires.json +++ b/seed_data/challenges/basic-bonfires.json @@ -866,7 +866,7 @@ }, { "_id": "a5deed1811a43193f9f1c841", - "name": "Bonfire: Drop it like it's hot", + "name": "Bonfire: Drop it", "difficulty": "2.13", "description": [ "Drop the elements of an array (first argument), starting from the front, until the predicate (second argument) returns true.", From 6b7ede6e1e6b2225a1c5c3b8673928ff662b9cb7 Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Tue, 26 May 2015 08:44:01 -0400 Subject: [PATCH 04/14] Update tests for smallest common multiple, this closes #507 --- seed_data/challenges/basic-bonfires.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed_data/challenges/basic-bonfires.json b/seed_data/challenges/basic-bonfires.json index 347421d44e..b35ce5c45b 100644 --- a/seed_data/challenges/basic-bonfires.json +++ b/seed_data/challenges/basic-bonfires.json @@ -836,7 +836,7 @@ "expect(smallestCommons([1,5])).to.be.a('number');", "expect(smallestCommons([1,5])).to.equal(60);", "expect(smallestCommons([5,1])).to.equal(60);", - "(smallestCommons([1,13])).should.equal(360360);" + "expect(smallestCommons([1,13])).to.equal(360360);" ], "MDNlinks" : ["Smallest Common Multiple"], "challengeType": 5 From 186d320d013d59adac948d46e094c7c44f6f8adf Mon Sep 17 00:00:00 2001 From: terakilobyte Date: Tue, 26 May 2015 09:14:10 -0400 Subject: [PATCH 05/14] version updates to force browser fetch so buttons works --- README.md | 2 +- ...HCJQFramework_0.1.2.js => coursewaresHCJQFramework_0.1.3.js} | 2 +- ...aresJSFramework_0.0.2.js => coursewaresJSFramework_0.0.3.js} | 0 .../{iFrameScripts_0.0.1.js => iFrameScripts_0.0.2.js} | 0 public/js/{main.js => main_0.0.1.js} | 0 views/coursewares/showBonfire.jade | 2 +- views/coursewares/showHTML.jade | 2 +- views/coursewares/showJS.jade | 2 +- views/partials/universal-head.jade | 2 +- 9 files changed, 6 insertions(+), 6 deletions(-) rename public/js/lib/coursewares/{coursewaresHCJQFramework_0.1.2.js => coursewaresHCJQFramework_0.1.3.js} (99%) rename public/js/lib/coursewares/{coursewaresJSFramework_0.0.2.js => coursewaresJSFramework_0.0.3.js} (100%) rename public/js/lib/coursewares/{iFrameScripts_0.0.1.js => iFrameScripts_0.0.2.js} (100%) rename public/js/{main.js => main_0.0.1.js} (100%) diff --git a/README.md b/README.md index e265bcf181..ea7af81a56 100644 --- a/README.md +++ b/README.md @@ -110,7 +110,7 @@ Project Structure | **models**/Challenge.js | Mongoose schema and model for Challenge. | | **public**/ | Static assets (fonts, css, js, img). | | **public**/**js**/application.js | Specify client-side JavaScript dependencies. | -| **public**/**js**/main.js | Place your client-side JavaScript here. | +| **public**/**js**/main_0.0.1.js | Place your client-side JavaScript here. | | **public**/**css**/main.less | Main stylesheet for the app. | | **views/account**/ | Templates for *login, password reset, signup, profile*. | | **views/partials**/flash.jade | Error, info and success flash notifications. | diff --git a/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.2.js b/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.3.js similarity index 99% rename from public/js/lib/coursewares/coursewaresHCJQFramework_0.1.2.js rename to public/js/lib/coursewares/coursewaresHCJQFramework_0.1.3.js index d3443ac6be..09248f6c38 100644 --- a/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.2.js +++ b/public/js/lib/coursewares/coursewaresHCJQFramework_0.1.3.js @@ -56,7 +56,7 @@ var allTests = ''; }); })(); -var otherTestsForNow = ""; +var otherTestsForNow = ""; var delay; // Initialize CodeMirror editor with a nice html5 canvas demo. diff --git a/public/js/lib/coursewares/coursewaresJSFramework_0.0.2.js b/public/js/lib/coursewares/coursewaresJSFramework_0.0.3.js similarity index 100% rename from public/js/lib/coursewares/coursewaresJSFramework_0.0.2.js rename to public/js/lib/coursewares/coursewaresJSFramework_0.0.3.js diff --git a/public/js/lib/coursewares/iFrameScripts_0.0.1.js b/public/js/lib/coursewares/iFrameScripts_0.0.2.js similarity index 100% rename from public/js/lib/coursewares/iFrameScripts_0.0.1.js rename to public/js/lib/coursewares/iFrameScripts_0.0.2.js diff --git a/public/js/main.js b/public/js/main_0.0.1.js similarity index 100% rename from public/js/main.js rename to public/js/main_0.0.1.js diff --git a/views/coursewares/showBonfire.jade b/views/coursewares/showBonfire.jade index 7e9e63e683..0823c8f923 100644 --- a/views/coursewares/showBonfire.jade +++ b/views/coursewares/showBonfire.jade @@ -125,7 +125,7 @@ block content form.code .form-group.codeMirrorView textarea#codeEditor(autofocus=true, style='display: none;') - script(src='/js/lib/coursewares/coursewaresJSFramework_0.0.2.js') + script(src='/js/lib/coursewares/coursewaresJSFramework_0.0.3.js') #complete-courseware-dialog.modal(tabindex='-1') .modal-dialog.animated.zoomIn.fast-animation diff --git a/views/coursewares/showHTML.jade b/views/coursewares/showHTML.jade index 4a8f42fad6..ed06f018d3 100644 --- a/views/coursewares/showHTML.jade +++ b/views/coursewares/showHTML.jade @@ -91,4 +91,4 @@ block content .animated.zoomInDown.delay-half span.completion-icon.ion-checkmark-circled.text-primary a.animated.fadeIn.btn.btn-lg.signup-btn.btn-block(href='/login') Sign in so you can save your progress - script(src="/js/lib/coursewares/coursewaresHCJQFramework_0.1.2.js") + script(src="/js/lib/coursewares/coursewaresHCJQFramework_0.1.3.js") diff --git a/views/coursewares/showJS.jade b/views/coursewares/showJS.jade index c32427ca22..c0b72b7247 100644 --- a/views/coursewares/showJS.jade +++ b/views/coursewares/showJS.jade @@ -67,7 +67,7 @@ block content form.code .form-group.codeMirrorView textarea#codeEditor(autofocus=true, style='display: none;') - script(src='/js/lib/coursewares/coursewaresJSFramework_0.0.2.js') + script(src='/js/lib/coursewares/coursewaresJSFramework_0.0.3.js') #complete-courseware-dialog.modal(tabindex='-1') .modal-dialog.animated.zoomIn.fast-animation .modal-content diff --git a/views/partials/universal-head.jade b/views/partials/universal-head.jade index 81b2895666..16df67a25b 100644 --- a/views/partials/universal-head.jade +++ b/views/partials/universal-head.jade @@ -32,7 +32,7 @@ script. window.moment || document.write('