From 2d5305af7ff7917938361a5fade5ec3d8906cb8b Mon Sep 17 00:00:00 2001 From: Oliver Eyton-Williams Date: Thu, 28 Oct 2021 12:02:10 +0200 Subject: [PATCH] fix: actually lint staged files on commit (#44036) --- .lintstagedrc.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.lintstagedrc.js b/.lintstagedrc.js index 2e58e1bb42..6fc72dd488 100644 --- a/.lintstagedrc.js +++ b/.lintstagedrc.js @@ -5,14 +5,18 @@ const cli = new ESLint(); // if a lot of files are changed, it's faster to run prettier/eslint on the // whole project than to run them on each file separately module.exports = { - '*.(js|ts|tsx)': files => - files.length > 10 + '*.(js|ts|tsx)': async files => { + const ignoredIds = await Promise.all( + files.map(file => cli.isPathIgnored(file)) + ); + const lintableFiles = files.filter((_, i) => !ignoredIds[i]); + return files.length > 10 ? ['eslint --max-warnings=0 --cache --fix .', 'prettier --write .'] : [ - 'eslint --max-warnings=0 --cache --fix ' + - files.filter(file => !cli.isPathIgnored(file)).join(' '), + 'eslint --max-warnings=0 --cache --fix ' + lintableFiles.join(' '), ...files.map(filename => `prettier --write '${filename}'`) - ], + ]; + }, '*.!(js|ts|tsx)': files => files.length > 10 ? 'prettier --write .'