From f606d49a680c270abe3322e65f8417a20826f2ac Mon Sep 17 00:00:00 2001 From: Michael Pope Date: Sat, 11 Jul 2015 10:49:28 -0400 Subject: [PATCH 1/7] Clarify text for 'Waypoint: Add a Negative Margin to an Element' - the user was asked to change text to a negative number - this was confusing, as the test only passes if the value ia -15px --- challenges/basic-html5-and-css.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/challenges/basic-html5-and-css.json b/challenges/basic-html5-and-css.json index bc93160d7b..8c81f5000d 100644 --- a/challenges/basic-html5-and-css.json +++ b/challenges/basic-html5-and-css.json @@ -2554,7 +2554,7 @@ "dashedName": "waypoint-add-a-negative-margin-to-an-element", "difficulty": 0.042, "description": [ - "Change the margin of the green box to a negative value, so it fills the entire horizontal width of the yellow box around it.", + "Change the margin of the green box to -15 pixels, so it fills the entire horizontal width of the yellow box around it.", "An element's margin controls the amount of space between an element's border and surrounding elements.", "If you set an element's margin to a negative value, the element will grow larger.", "Try to set the margin to a negative value like the one for the red box." From da9637297b740710e9ad84c2b3c10f061211eae2 Mon Sep 17 00:00:00 2001 From: Sean Nguyen Date: Mon, 13 Jul 2015 13:20:28 -0700 Subject: [PATCH 2/7] Add

element to label the new ordered list. - Improve consistency of challenge seeds - Clarify challenge objective for "Waypoint: Created an ordered list" --- challenges/basic-html5-and-css.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/challenges/basic-html5-and-css.json b/challenges/basic-html5-and-css.json index bc93160d7b..961c604c29 100644 --- a/challenges/basic-html5-and-css.json +++ b/challenges/basic-html5-and-css.json @@ -1527,7 +1527,8 @@ "

  • cat nip
    • ", "
  • laser pointers
    • ", "
  • lasagna
    • ", - "" + "", + "

    Top 3 things cats hate:

    " ], "challengeType": 0, "nameCn": "", From f8b5efefbbd0d9a1957d39756f233138f347e244 Mon Sep 17 00:00:00 2001 From: Jose M Viloria Date: Sat, 11 Jul 2015 22:12:22 -0430 Subject: [PATCH 3/7] Typo in Waypoint #38 Deleted extra semicolon. --- challenges/html5-and-css.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/challenges/html5-and-css.json b/challenges/html5-and-css.json index 8a833a05a4..3d0f52b42e 100644 --- a/challenges/html5-and-css.json +++ b/challenges/html5-and-css.json @@ -2151,7 +2151,7 @@ "Set the first of your radio buttons and the first of your checkboxes to both be checked by default." ], "tests": [ - "assert($('input[type=\"radio\"]').prop('checked'), 'Your first radio button on your form should be checked by default.');", + "assert($('input[type=\"radio\"]').prop('checked'), 'Your first radio button on your form should be checked by default.')", "assert($('input[type=\"checkbox\"]').prop('checked'), 'Your first checkbox on your form should be checked by default.')" ], "challengeSeed": [ From 735ed1c3ec24390a571054800a21ac9301902e27 Mon Sep 17 00:00:00 2001 From: LumenTeun Date: Sat, 11 Jul 2015 00:46:19 +0200 Subject: [PATCH 4/7] 'Create a Text Field' now makes sure the input type is text. #1241 --- challenges/html5-and-css.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/challenges/html5-and-css.json b/challenges/html5-and-css.json index e0ad812245..7cbb0d11c7 100644 --- a/challenges/html5-and-css.json +++ b/challenges/html5-and-css.json @@ -1562,7 +1562,7 @@ "Create an input element of type \"text\" below your lists." ], "tests": [ - "assert($('input').length > 0, 'Your app should have a text field input element.')" + "assert($('input[type=text]').length > 0, 'Your app should have a text field input element.')" ], "challengeSeed": [ "", From df6465da3eaa023dd6d4a9e4acc94de5e01b5535 Mon Sep 17 00:00:00 2001 From: benmcmahon100 Date: Sun, 2 Aug 2015 21:15:39 +0100 Subject: [PATCH 5/7] Fixed the fact it was myDecimal instead of myFloat --- challenges/basic-javascript.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/challenges/basic-javascript.json b/challenges/basic-javascript.json index 5a2a5a28eb..f1f1a21f89 100644 --- a/challenges/basic-javascript.json +++ b/challenges/basic-javascript.json @@ -368,14 +368,14 @@ "description": [ "", "in JavaScript we can can work with decimal numbers", - "Let's create a variable myfloat and give it a decimal value." + "Let's create a variable myDecimal and give it a decimal value." ], "tests": [ - "assert((function(){if(typeof(myDecimal) != 'undefined' && typeof(myDecimal) == 'number' && editor.getValue().match(/\\./g).length >=2){return(true);}else{return(false);}})(), 'myFloat should be a decimal point number');" + "assert((function(){if(typeof(myDecimal) != 'undefined' && typeof(myDecimal) == 'number' && editor.getValue().match(/\\./g).length >=2){return(true);}else{return(false);}})(), 'myDecimal should be a decimal point number');" ], "challengeSeed": [ "//var ourDecimal = 5.7", - "//Create a number with a decimal point here called myFloat", + "//Create a number with a decimal point here called myDecimal", "", "", "", From 5bfd381e65f6dd38ec2f2616bb1484f55d9ee050 Mon Sep 17 00:00:00 2001 From: benmcmahon100 Date: Sun, 2 Aug 2015 21:24:13 +0100 Subject: [PATCH 6/7] Allows users to add values to the inner arrays --- challenges/basic-javascript.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/challenges/basic-javascript.json b/challenges/basic-javascript.json index f1f1a21f89..2e9e21ffe2 100644 --- a/challenges/basic-javascript.json +++ b/challenges/basic-javascript.json @@ -448,7 +448,7 @@ "Let's now go create a nested array called myArray" ], "tests":[ - "assert((function(){if(typeof(myArray) !== 'undefined' && typeof(myArray) === 'object' && typeof(myArray[0]) !== 'undefined' && typeof(myArray[0]) === 'object' && editor.getValue().match(/[[]]/g).length >= 1){return(true);}else{return(false);}})(), 'myArray should contain at least one array');" + "assert((function(){if(typeof(myArray) !== 'undefined' && typeof(myArray) === 'object' && typeof(myArray[0]) !== 'undefined' && typeof(myArray[0]) === 'object' && editor.getValue().match(/\\[\\[/g).length >= 1 && editor.getValue().match(/\\]\\]/g).length >= 1){return(true);}else{return(false);}})(), 'myArray should contain at least one array');" ], "challengeSeed":[ "var myArray = [];", From 10156ea245f8322775939536b9c82ead805befa7 Mon Sep 17 00:00:00 2001 From: benmcmahon100 Date: Sun, 2 Aug 2015 22:09:36 +0100 Subject: [PATCH 7/7] Two of the tests were inverted --- challenges/jquery-ajax-and-json.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/challenges/jquery-ajax-and-json.json b/challenges/jquery-ajax-and-json.json index 53674a7280..92509ffade 100644 --- a/challenges/jquery-ajax-and-json.json +++ b/challenges/jquery-ajax-and-json.json @@ -112,7 +112,7 @@ ], "tests": [ "assert($('.well').hasClass('animated') && $('.well').hasClass('shake'), 'Use the jQuery addClass() function to give the classes \"animated\" and \"shake\" to all your elements with the class \"well\".')", - "assert(!editor.match(/class.*animated/g), 'Only use jQuery to add these classes to the element.')" + "assert(!editor.match(/class\\.\\*animated/g), 'Only use jQuery to add these classes to the element.')" ], "challengeSeed": [ "fccss", @@ -630,8 +630,8 @@ ], "tests": [ "assert($('#left-well').css('background-color') === 'rgb(255, 0, 0)', 'Your \"target1\" element should have red text.')", - "assert(!editor.match(/\\.parent\\(\\)\\.css/g), 'You should use the parent() function to modify this element.')", - "assert(!editor.match(/
    /g), 'Only use jQuery to add these classes to the element.')" + "assert(editor.match(/\\.parent\\(\\)\\.css/g), 'You should use the parent() function to modify this element.')", + "assert(editor.match(/
    /g), 'Only use jQuery to add these classes to the element.')" ], "challengeSeed": [ "fccss",