gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(tools): update challege formatting check

Browse Source
This commit is contained in:
Mrugesh Mohapatra
2019-08-01 20:13:05 +05:30
committed by mrugesh
parent 3ec1fe8ea7
commit 31f337f2bd
2 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
curriculum/schema/challengeSchema.js
View File

@ -41,6 +41,7 @@ function getSchemaForLang(lang) {
),
guideUrl: Joi.string().uri({ scheme: 'https' }),
videoUrl: Joi.string().allow(''),
forumTopicId: Joi.number(),
helpRoom: Joi.string(),
id: Joi.objectId().required(),
instructions: Joi.string().allow(''),

21
tools/scripts/ci/ensure-challenge-formatting.js
View File

@ -51,21 +51,26 @@ const challengeFrontmatterValidator = file => frontmatter => {
`);
}
const { videoUrl } = frontmatter;
let validVideoUrl = false;
if (isEmpty(videoUrl)) {
if (!isEmpty(videoUrl) && !scrimbaUrlRE.test(videoUrl)) {
validVideoUrl = true;
} else {
validVideoUrl = scrimbaUrlRE.test(videoUrl);
if (!validVideoUrl) {
console.log(`
${fullPath} contains an invalid videoUrl
`);
`);
}
const { forumTopicId } = frontmatter;
let validForumTopicId = false;
if (!isEmpty(forumTopicId) && !isNumber(forumTopicId)) {
validForumTopicId = true;
console.log(`
${fullPath} contains an invalid forumTopicId
`);
}
return hasRequiredProperties && validVideoUrl;
return hasRequiredProperties && validVideoUrl && validForumTopicId;
};
function isChallengeParseable(file) {