fix:Incorrect Usage of setState in React Challenge (#39290)

* fix:Incorrect Usaage of setState in React Challenge

* apply suggestion

* also set stage usage in other challenges

* fix setState usage in challenges

* correct syntax

* correct usage of useState in other files

* add current message to state

* remove current message from state

* change connect redux to the message app

* remove extra space
This commit is contained in:
Ruchi Kushwaha
2020-08-11 22:42:27 +05:30
committed by GitHub
parent 817325d68e
commit 35c3609489
8 changed files with 55 additions and 45 deletions

View File

@ -85,10 +85,12 @@ class Presentational extends React.Component {
}); });
} }
submitMessage() { submitMessage() {
const currentMessage = this.state.input; this.setState((state) => {
this.setState({ const currentMessage = state.input;
input: '', return {
messages: this.state.messages.concat(currentMessage) input: '',
messages: state.messages.concat(currentMessage)
};
}); });
} }
render() { render() {
@ -202,10 +204,12 @@ class Presentational extends React.Component {
}); });
} }
submitMessage() { submitMessage() {
const currentMessage = this.state.input; this.setState((state) => {
this.setState({ const currentMessage = state.input;
input: '', return {
messages: this.state.messages.concat(currentMessage) input: '',
messages: state.messages.concat(currentMessage)
};
}); });
} }
render() { render() {

View File

@ -97,10 +97,10 @@ class Presentational extends React.Component {
}); });
} }
submitMessage() { submitMessage() {
this.setState({ this.setState((state) => ({
input: '', input: '',
messages: this.state.messages.concat(this.state.input) messages: state.messages.concat(state.input)
}); }));
} }
render() { render() {
return ( return (

View File

@ -107,10 +107,12 @@ class DisplayMessages extends React.Component {
}); });
} }
submitMessage() { submitMessage() {
const currentMessage = this.state.input; this.setState((state) => {
this.setState({ const currentMessage = state.input;
input: '', return {
messages: this.state.messages.concat(currentMessage) input: '',
messages: state.messages.concat(currentMessage)
};
}); });
} }
render() { render() {

View File

@ -93,11 +93,13 @@ class DisplayMessages extends React.Component {
input: event.target.value input: event.target.value
}); });
} }
submitMessage() { submitMessage() {
const currentMessage = this.state.input; this.setState((state) => {
this.setState({ const currentMessage = state.input;
input: '', return {
messages: this.state.messages.concat(currentMessage) input: '',
messages: state.messages.concat(currentMessage)
};
}); });
} }
render() { render() {
@ -191,10 +193,12 @@ class DisplayMessages extends React.Component {
}); });
} }
submitMessage() { submitMessage() {
const currentMessage = this.state.input; this.setState((state) => {
this.setState({ const currentMessage = state.input;
input: '', return {
messages: this.state.messages.concat(currentMessage) input: '',
messages: state.messages.concat(currentMessage)
};
}); });
} }
render() { render() {

View File

@ -61,9 +61,9 @@ class MyComponent extends React.Component {
} }
// change code above this line // change code above this line
handleEnter() { handleEnter() {
this.setState({ this.setState((state) => ({
message: this.state.message + 'You pressed the enter key! ' message: state.message + 'You pressed the enter key! '
}); }));
} }
handleKeyPress(event) { handleKeyPress(event) {
if (event.keyCode === 13) { if (event.keyCode === 13) {
@ -118,9 +118,9 @@ class MyComponent extends React.Component {
// change code above this line // change code above this line
} }
handleEnter() { handleEnter() {
this.setState({ this.setState((state) => ({
message: this.state.message + 'You pressed the enter key! ' message: state.message + 'You pressed the enter key! '
}); }));
} }
handleKeyPress(event) { handleKeyPress(event) {
if (event.keyCode === 13) { if (event.keyCode === 13) {

View File

@ -120,9 +120,9 @@ class MyForm extends React.Component {
} }
handleSubmit(event) { handleSubmit(event) {
event.preventDefault() event.preventDefault()
this.setState({ this.setState((state) => ({
submit: this.state.input submit: state.input
}); }));
} }
render() { render() {
return ( return (

View File

@ -69,9 +69,9 @@ class Controller extends React.Component {
this.addValue = this.addValue.bind(this); this.addValue = this.addValue.bind(this);
} }
addValue() { addValue() {
this.setState({ this.setState((state) => ({
value: this.state.value + 1 value: state.value + 1
}); }));
} }
render() { render() {
return ( return (
@ -130,9 +130,9 @@ class Controller extends React.Component {
this.addValue = this.addValue.bind(this); this.addValue = this.addValue.bind(this);
} }
addValue() { addValue() {
this.setState({ this.setState((state) => ({
value: this.state.value + 1 value: state.value + 1
}); }));
} }
render() { render() {
return ( return (

View File

@ -51,9 +51,9 @@ class MyComponent extends React.Component {
this.toggleDisplay = this.toggleDisplay.bind(this); this.toggleDisplay = this.toggleDisplay.bind(this);
} }
toggleDisplay() { toggleDisplay() {
this.setState({ this.setState((state) => ({
display: !this.state.display display: !state.display
}); }));
} }
render() { render() {
// change code below this line // change code below this line
@ -96,9 +96,9 @@ class MyComponent extends React.Component {
this.toggleDisplay = this.toggleDisplay.bind(this); this.toggleDisplay = this.toggleDisplay.bind(this);
} }
toggleDisplay() { toggleDisplay() {
this.setState({ this.setState((state) => ({
display: !this.state.display display: !state.display
}); }));
} }
render() { render() {
// change code below this line // change code below this line