From c10f81408a4d4097ae1bfadb2a35496ee0315554 Mon Sep 17 00:00:00 2001 From: Berkeley Martinez Date: Wed, 9 Sep 2015 12:52:31 -0700 Subject: [PATCH] add ctrl enter press to submit on modal this adds the ability for a camper to press ctrl + enter to submit a challenge while the challenge completion modal is open --- client/commonFramework.js | 8 ++++++++ server/views/coursewares/showBonfire.jade | 2 +- server/views/coursewares/showHTML.jade | 2 +- server/views/coursewares/showJS.jade | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/client/commonFramework.js b/client/commonFramework.js index be5be4533c..890e042db7 100644 --- a/client/commonFramework.js +++ b/client/commonFramework.js @@ -423,6 +423,14 @@ function showCompletion() { var didCompleteWith = $('#completed-with').val() || null; $('#complete-courseware-dialog').modal('show'); $('#complete-courseware-dialog .modal-header').click(); + + $('#complete-courseware-dialog').keyup(function(e) { + // ctrl + enter + if (e.ctrlKey && e.keyCode === 13) { + $('#submit-challenge').click(); + } + }); + $('#submit-challenge').click(function(e) { e.preventDefault(); diff --git a/server/views/coursewares/showBonfire.jade b/server/views/coursewares/showBonfire.jade index bbc247bb40..66ab364b95 100644 --- a/server/views/coursewares/showBonfire.jade +++ b/server/views/coursewares/showBonfire.jade @@ -140,7 +140,7 @@ block content .spacer .row if (user) - #submit-challenge.animated.fadeIn.btn.btn-lg.btn-primary.btn-block Submit and go to next challenge + #submit-challenge.animated.fadeIn.btn.btn-lg.btn-primary.btn-block Submit and go to next challenge (Ctrl + enter) if (user.progressTimestamps.length > 2) a.animated.fadeIn.btn.btn-lg.btn-block.btn-twitter(target="_blank", href="https://twitter.com/intent/tweet?text=I%20just%20#{verb}%20%40FreeCodeCamp%20#{name}&url=http%3A%2F%2Ffreecodecamp.com/challenges/#{dashedName}&hashtags=LearnToCode, JavaScript") diff --git a/server/views/coursewares/showHTML.jade b/server/views/coursewares/showHTML.jade index 64a10cc314..972c3d59df 100644 --- a/server/views/coursewares/showHTML.jade +++ b/server/views/coursewares/showHTML.jade @@ -91,7 +91,7 @@ block content span.completion-icon.ion-checkmark-circled.text-primary .spacer if(user) - #submit-challenge.animated.fadeIn.btn.btn-lg.btn-primary.btn-block Submit and go to next challenge + #submit-challenge.animated.fadeIn.btn.btn-lg.btn-primary.btn-block Submit and go to next challenge (Ctrl + enter) else a.animated.fadeIn.btn.btn-lg.signup-btn.btn-block(href='/login') Sign in so you can save your progress include ../partials/challenge-modals diff --git a/server/views/coursewares/showJS.jade b/server/views/coursewares/showJS.jade index f0832f8387..8991002423 100644 --- a/server/views/coursewares/showJS.jade +++ b/server/views/coursewares/showJS.jade @@ -87,7 +87,7 @@ block content .spacer .row if (user) - #submit-challenge.animated.fadeIn.btn.btn-lg.btn-primary.btn-block Submit and go to next challenge + #submit-challenge.animated.fadeIn.btn.btn-lg.btn-primary.btn-block Submit and go to next challenge (Ctrl + enter) if (user.progressTimestamps.length > 2) a.animated.fadeIn.btn.btn-lg.btn-block.btn-twitter(target="_blank", href="https://twitter.com/intent/tweet?text=I%20just%20#{verb}%20%40FreeCodeCamp%20#{name}&url=http%3A%2F%2Ffreecodecamp.com/challenges/#{dashedName}&hashtags=LearnToCode, JavaScript") i.fa.fa-twitter