From 3ed1f732211f6f6578014fd86f31978ad905ca82 Mon Sep 17 00:00:00 2001 From: awu43 <46470763+awu43@users.noreply.github.com> Date: Mon, 19 Jul 2021 05:18:17 -0700 Subject: [PATCH] fix(client): remove unnecessary return values (#42927) * remove returns * change .some() to .includes() --- client/gatsby-node.js | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/client/gatsby-node.js b/client/gatsby-node.js index c5e986d56d..243ad2c671 100644 --- a/client/gatsby-node.js +++ b/client/gatsby-node.js @@ -132,26 +132,22 @@ exports.createPages = function createPages({ graphql, actions, reporter }) { } = edge; if (!fields) { - return null; + return; } const { slug, nodeIdentity } = fields; if (slug.includes('LICENCE')) { - return null; + return; } try { if (nodeIdentity === 'blockIntroMarkdown') { - if (!blocks.some(block => block === frontmatter.block)) { - return null; + if (!blocks.includes(frontmatter.block)) { + return; } - } else if ( - !superBlocks.some( - superBlock => superBlock === frontmatter.superBlock - ) - ) { - return null; + } else if (!superBlocks.includes(frontmatter.superBlock)) { + return; } const pageBuilder = createByIdentityMap[nodeIdentity](createPage); - return pageBuilder(edge); + pageBuilder(edge); } catch (e) { console.log(` ident: ${nodeIdentity} does not belong to a function @@ -161,7 +157,6 @@ exports.createPages = function createPages({ graphql, actions, reporter }) { `); } - return null; }); return null;