diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e1564eb1f0..0b52ff2b32 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,21 +1,27 @@ ## FreeCodeCamp Pull Request template -Please, go through steps before you submit a PR. +Please, go through these steps before you submit a PR. 1. Make sure that your PR is not a duplicate. -2. If not then: +2. If not, then make sure that: - 2.1. Make sure you've done your changes in a separate branch, like `fix/signin-issue` or `feature/issue-templates`. + 2.1. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the `fix/` or `feature/` prefixes. Good examples are: `fix/signin-issue` or `feature/issue-templates`. - 2.2. You have a descriptive commit message. + 2.2. You have a descriptive commit message with a short title (first line). 2.3. You have only one commit (if not, [squash](https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/git-rebase#squashing-multiple-commits-into-one) them into one commit). - 2.4. Make sure `npm test` doesn't throw any error. If it does, fix them first and amend your commit. + 2.4. `npm test` doesn't throw any error. If it does, fix them first and amend your commit (`git commit --amend`). -3. **After** these steps you're ready to open a pull request. ***Don't*** forget to remove this template first. +3. **After** these steps, you're ready to open a pull request. - 3.1. Give a descriptive title to your PR. + 3.1. Your pull request MUST NOT target the `master` branch on FreeCodeCamp's repository. You probably want to target `staging` instead. - 3.2. Provide a description of your changes. + 3.2. Give a descriptive title to your PR. - 3.3. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). + 3.3. Provide a description of your changes. + + 3.4. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). + +IMPORTANT: Please review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines. + +**PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING** diff --git a/client/less/main.less b/client/less/main.less index 8ce2c43f63..8ae2225ba5 100644 --- a/client/less/main.less +++ b/client/less/main.less @@ -301,7 +301,7 @@ ul { border: none; line-height: 1; @media (min-width: 767px) { - padding-left: 30px; + padding-left: 15px; padding-right: 30px; } } diff --git a/client/less/map.less b/client/less/map.less index 4b1a4df3f4..09af131ca8 100644 --- a/client/less/map.less +++ b/client/less/map.less @@ -40,18 +40,9 @@ background-color: @body-bg; } - .iframeWrapper { - height:100%; - width:100%; - overflow-x: hidden; - overflow-y: scroll; - -webkit-overflow-scrolling: touch; - iframe { - flex: 1; - width: 100%; - height: 100%; - border: 0; - } + iframe { + width: 100%; + height: 100%; } } @@ -139,10 +130,16 @@ } } +.mapWrapper { + position:absolute; + display: block; + height: 100%; + width: 100%; +} + .map-accordion { - margin: 135px auto 0; - width:700px; - overflow-y: auto; + width:700px; + margin:155px auto 0; position:relative; #nested { margin:0 15px; @@ -228,10 +225,19 @@ left:0; right:0; width:100%; - margin-top:180px; + top:195px; + bottom:0; + margin:0; + position:absolute; + overflow-x: hidden; + overflow-y: auto; + -webkit-overflow-scrolling: touch; h2 { margin:15px 0; padding:0; + &:first-of-type { + margin-top:0; + } > a { padding:10px 0; padding-left:50px; @@ -249,7 +255,7 @@ } } } - + .map-aside-action-item { display: -webkit-flex; display: flex; diff --git a/client/less/wiki.less b/client/less/wiki.less index c8d9ad96d0..b5731a84ef 100644 --- a/client/less/wiki.less +++ b/client/less/wiki.less @@ -6,7 +6,6 @@ #wikiFrame { width: 100%; height: 100%; - padding-top: 30px; top:0; bottom: 0; position: absolute; @@ -53,18 +52,13 @@ background-color: @body-bg; } - .iframeWrapper { - height:100%; - width:100%; - overflow-x: hidden; - overflow-y: scroll; - -webkit-overflow-scrolling: touch; - iframe { - flex: 1; - width: 100%; - height: 100%; - border: 0; - } + iframe { + width: 100%; + height: 100%; + top:0; + bottom:0; + position:absolute; + overflow: hidden; } } @@ -83,14 +77,14 @@ .wiki-aside-action-bar { position: absolute; top: 0; - right: 0; + right: 15px; display: -webkit-flex; display: flex; justify-content: flex-end; padding-bottom: 5px; - padding-right:10px; + padding-right:0px; padding-top:5px; z-index: 100; } diff --git a/client/main.js b/client/main.js index e38789ac6c..7ae02eef75 100644 --- a/client/main.js +++ b/client/main.js @@ -357,9 +357,9 @@ $(document).ready(function() { var mapAside = $('