gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix add missing return

Browse Source 
add notes
This commit is contained in:
Berkeley Martinez
2015-05-21 00:17:44 -07:00
parent 4ad757ebd5
commit 3f690629b0
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
controllers/challenge.js
View File

@ -139,7 +139,7 @@ exports.returnIndividualChallenge = function(req, res, next) {
Challenge.find({'name': new RegExp(challengeName, 'i')}, Challenge.find({'name': new RegExp(challengeName, 'i')},
function(err, challengeFromMongo) { function(err, challengeFromMongo) {
if (err) { if (err) {
next(err); return next(err);
} }
// Handle not found // Handle not found
if (challengeFromMongo.length < 1) { if (challengeFromMongo.length < 1) {
@ -292,8 +292,8 @@ exports.completedBonfire = function (req, res, next) {
var challengeName = req.body.challengeInfo.challengeName; var challengeName = req.body.challengeInfo.challengeName;
if (isCompletedWith) { if (isCompletedWith) {
var paired = User.find({'profile.username': isCompletedWith var paired = User.find({'profile.username': isCompletedWith.toLowerCase()})
.toLowerCase()}).limit(1); .limit(1);
paired.exec(function (err, pairedWith) { paired.exec(function (err, pairedWith) {
if (err) { if (err) {
return next(err); return next(err);
@ -366,6 +366,7 @@ exports.completedBonfire = function (req, res, next) {
if (err) { if (err) {
return next(err); return next(err);
} }
// NOTE(berks): Under certain conditions the res is never ended
if (user) { if (user) {
res.send(true); res.send(true);
} }
@ -420,7 +421,9 @@ exports.completedZiplineOrBasejump = function (req, res, next) {
} }
if (isCompletedWith) { if (isCompletedWith) {
var paired = User.find({'profile.username': isCompletedWith.toLowerCase()}).limit(1); var paired = User.find({'profile.username': isCompletedWith.toLowerCase()})
.limit(1);
paired.exec(function (err, pairedWithFromMongo) { paired.exec(function (err, pairedWithFromMongo) {
if (err) { if (err) {
return next(err); return next(err);
@ -499,6 +502,7 @@ exports.completedZiplineOrBasejump = function (req, res, next) {
if (err) { if (err) {
return next(err); return next(err);
} }
// NOTE(berks): under certain conditions this will not close the response.
if (user) { if (user) {
return res.sendStatus(200); return res.sendStatus(200);
} }