gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(client): reset test results before execution (#36029)

Browse Source 
* fixed issue where tests should fail when code has error

Signed-off-by: Stevo99 <Sfailla1983@gmail.com>

* fix(client): Initialize tests as failing in case of build errors

* fix: Reset tests to initial state when build fails

* fix: simplify expression
This commit is contained in:
Steven Failla
2019-05-26 17:00:12 -04:00
committed by Valeriy
parent 1e1cbdfe06
commit 43a4fa8cb0
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
client/src/templates/Challenges/redux/execute-challenge-saga.js
View File

@ -36,9 +36,16 @@ export function* executeChallengeSaga() {
} }
const consoleProxy = yield channel(); const consoleProxy = yield channel();
try { try {
yield put(initLogs()); yield put(initLogs());
yield put(initConsole('// running tests')); yield put(initConsole('// running tests'));
// reset tests to initial state
const tests = (yield select(challengeTestsSelector)).map(
({ text, testString }) => ({ text, testString })
);
yield put(updateTests(tests));
yield fork(logToConsole, consoleProxy); yield fork(logToConsole, consoleProxy);
const proxyLogger = args => consoleProxy.put(args); const proxyLogger = args => consoleProxy.put(args);
@ -51,7 +58,7 @@ export function* executeChallengeSaga() {
proxyLogger, proxyLogger,
document document
); );
const testResults = yield executeTests(testRunner); const testResults = yield executeTests(testRunner, tests);
yield put(updateTests(testResults)); yield put(updateTests(testResults));
yield put(updateConsole('// tests completed')); yield put(updateConsole('// tests completed'));
@ -79,9 +86,7 @@ function* buildChallengeData(challengeData) {
} }
} }
function* executeTests(testRunner) { function* executeTests(testRunner, tests, testTimeout = 5000) {
const tests = yield select(challengeTestsSelector);
const testTimeout = 5000;
const testResults = []; const testResults = [];
for (const { text, testString } of tests) { for (const { text, testString } of tests) {
const newTest = { text, testString }; const newTest = { text, testString };