feat: use static query to get idToNameMap (#36722)

api-server/common/models/challenge.js

@@ -1,56 +0,0 @@
-import { Observable } from 'rx';
-import { isEmpty } from 'lodash';
-import { dasherize } from '../utils';
-
-export default function(Challenge) {
-  let challengeIdToNameMap;
-
-  Challenge.on('dataSourceAttached', () => {
-    Challenge.findOne$ = Observable.fromNodeCallback(
-      Challenge.findOne,
-      Challenge
-    );
-    Challenge.findById$ = Observable.fromNodeCallback(
-      Challenge.findById,
-      Challenge
-    );
-    Challenge.find$ = Observable.fromNodeCallback(Challenge.find, Challenge);
-
-    Challenge.find({ isPrivate: false }, (err, challenges) => {
-      if (err) {
-        throw Error(err);
-      }
-      challengeIdToNameMap = challenges.reduce((map, challenge) => {
-        const { id, block, dashedName, title, superBlock } = challenge;
-        map[id] = {
-          challengeTitle: title,
-          challengePath: `${superBlock}/${dasherize(block)}/${dashedName}`
-        };
-        return map;
-      }, {});
-    });
-
-    function getIdToNameMap(cb) {
-      if (isEmpty(challengeIdToNameMap)) {
-        // We are waiting for the find query to resolve
-        return setTimeout(() => getIdToNameMap(cb), 50);
-      }
-      return cb(null, challengeIdToNameMap);
-    }
-    Challenge.getIdToNameMap = getIdToNameMap;
-  });
-
-  Challenge.remoteMethod('getIdToNameMap', {
-    returns: [
-      {
-        arg: 'user',
-        type: 'object',
-        root: true
-      }
-    ],
-    http: {
-      path: '/get-id-to-name',
-      verb: 'GET'
-    }
-  });
-}

api-server/common/models/challenge.json

@@ -133,13 +133,6 @@
       "principalType": "ROLE",
       "principalId": "$everyone",
       "permission": "ALLOW"
-    },
-    {
-      "accessType": "EXECUTE",
-      "principalType": "ROLE",
-      "principalId": "$everyone",
-      "permission": "ALLOW",
-      "property": "getIdToNameMap"
     }
   ],
   "methods": {}