gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: use position: fixed to avoid forcing Cypress (#39605)

Browse Source
This commit is contained in:
Oliver Eyton-Williams 2020-09-23 17:15:21 +02:00 committed by GitHub
parent 2f4d1c2804
commit 4f0959df1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/src/components/Header/components/universalNav.css
View File

@ -9,7 +9,7 @@
font-family: 'Lato', sans-serif; font-family: 'Lato', sans-serif;
height: var(--header-height); height: var(--header-height);
background: var(--theme-color); background: var(--theme-color);
position: absolute; position: fixed;
z-index: 1000; z-index: 1000;
color: var(--gray-00); color: var(--gray-00);
width: 100%; width: 100%;

16
cypress/integration/learn/index.js
View File

@ -52,7 +52,7 @@ describe('Learn Landing page (not logged in)', () => {
describe('Quotes', () => { describe('Quotes', () => {
beforeEach(() => { beforeEach(() => {
cy.visit('/'); cy.visit('/');
cy.contains("Get started (it's free)").click({ force: true }); cy.contains("Get started (it's free)").click();
}); });
it('Should show a quote', () => { it('Should show a quote', () => {
@ -71,7 +71,7 @@ describe('Quotes', () => {
describe('Superblocks and Blocks', () => { describe('Superblocks and Blocks', () => {
beforeEach(() => { beforeEach(() => {
cy.visit('/'); cy.visit('/');
cy.contains("Get started (it's free)").click({ force: true }); cy.contains("Get started (it's free)").click();
}); });
it('Has first superblock and block collapsed by default', () => { it('Has first superblock and block collapsed by default', () => {
@ -93,30 +93,26 @@ describe('Superblocks and Blocks', () => {
}); });
it('Superblocks should be collapsable and foldable', () => { it('Superblocks should be collapsable and foldable', () => {
cy.contains(superBlockNames[0]) cy.contains(superBlockNames[0])
.click({ .click()
force: true
})
.should('have.attr', 'aria-expanded', 'false'); .should('have.attr', 'aria-expanded', 'false');
cy.contains('Basic HTML and HTML5').should('not.be.visible'); cy.contains('Basic HTML and HTML5').should('not.be.visible');
cy.contains(superBlockNames[0]) cy.contains(superBlockNames[0])
.click({ .click()
force: true
})
.should('have.attr', 'aria-expanded', 'true'); .should('have.attr', 'aria-expanded', 'true');
cy.contains('Basic HTML and HTML5').should('be.visible'); cy.contains('Basic HTML and HTML5').should('be.visible');
}); });
it('Blocks should be collapsable and foldable', () => { it('Blocks should be collapsable and foldable', () => {
cy.contains('Basic HTML and HTML5') cy.contains('Basic HTML and HTML5')
.click({ force: true }) .click()
.should('have.attr', 'aria-expanded', 'false'); .should('have.attr', 'aria-expanded', 'false');
cy.contains('Introduction to Basic HTML and HTML5').should( cy.contains('Introduction to Basic HTML and HTML5').should(
'not.be.visible' 'not.be.visible'
); );
cy.contains('Basic HTML and HTML5') cy.contains('Basic HTML and HTML5')
.click({ force: true }) .click()
.should('have.attr', 'aria-expanded', 'true'); .should('have.attr', 'aria-expanded', 'true');
cy.contains('Introduction to Basic HTML and HTML5').should('be.visible'); cy.contains('Introduction to Basic HTML and HTML5').should('be.visible');
}); });

4
cypress/integration/learn/navigation-buttons/update-my-account-settings-button.js
View File

@ -4,7 +4,7 @@ describe('The `Update my account settings` button works properly', function() {
beforeEach(() => { beforeEach(() => {
cy.visit('/'); cy.visit('/');
cy.contains("Get started (it's free)").click({ force: true }); cy.contains("Get started (it's free)").click();
}); });
it('Should get rendered', function() { it('Should get rendered', function() {
@ -17,7 +17,7 @@ describe('The `Update my account settings` button works properly', function() {
}); });
it('Should take user to their account settings when clicked', function() { it('Should take user to their account settings when clicked', function() {
cy.contains('Update my account settings').click({ force: true }); cy.contains('Update my account settings').click();
cy.url().should('include', '/settings'); cy.url().should('include', '/settings');
}); });
}); });

4
cypress/integration/learn/navigation-buttons/view-portfolio-button.js
View File

@ -4,7 +4,7 @@ describe('The `View my Portfolio` button works properly', function() {
beforeEach(() => { beforeEach(() => {
cy.visit('/'); cy.visit('/');
cy.contains("Get started (it's free)").click({ force: true }); cy.contains("Get started (it's free)").click();
}); });
it('Button gets rendered', function() { it('Button gets rendered', function() {
@ -17,7 +17,7 @@ describe('The `View my Portfolio` button works properly', function() {
}); });
it('Button takes user to their portfolio when clicked', function() { it('Button takes user to their portfolio when clicked', function() {
cy.contains('View my Portfolio').click({ force: true }); cy.contains('View my Portfolio').click();
cy.url().should('include', '/developmentuser'); cy.url().should('include', '/developmentuser');
}); });
}); });