gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor: sortFiles -> toSortedArray

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2020-07-08 16:23:09 +02:00
committed by Mrugesh Mohapatra
parent 1ee5e24d0f
commit 52cb6adf02
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
utils/sort-files.js
View File

@@ -1,4 +1,4 @@
exports.sortFiles = function sortFiles(challengeFiles) {
exports.toSortedArray = function toSortedArray(challengeFiles) {
const xs = Object.values(challengeFiles);
// TODO: refactor this to use an ext array ['html', 'js', 'css'] and loop over
// that.

10
utils/sort-files.test.js
View File

@@ -1,23 +1,23 @@
/* global expect */
const { sortFiles } = require('./sort-files');
const { toSortedArray } = require('./sort-files');
const { challengeFiles } = require('./__fixtures__/challenges');
describe('sort-files', () => {
describe('sortFiles', () => {
describe('toSortedArray', () => {
it('should return an array', () => {
const sorted = sortFiles(challengeFiles);
const sorted = toSortedArray(challengeFiles);
expect(Array.isArray(sorted)).toBe(true);
});
it('should not modify the challenges', () => {
const sorted = sortFiles(challengeFiles);
const sorted = toSortedArray(challengeFiles);
const expected = Object.values(challengeFiles);
expect(sorted).toEqual(expect.arrayContaining(expected));
expect(sorted.length).toEqual(expected.length);
});
it('should sort the objects into html, js, css order', () => {
const sorted = sortFiles(challengeFiles);
const sorted = toSortedArray(challengeFiles);
const sortedKeys = sorted.map(({ key }) => key);
const expected = ['indexhtml', 'indexjsx', 'indexjs', 'indexcss'];
expect(sortedKeys).toStrictEqual(expected);