refactor: files{} -> challengeFiles[], and key -> fileKey (#43023)

* fix(client): fix client

* fix propType and add comment

* revert user.json prettification

* slight type refactor and payload correction

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* update ChallengeFile type imports

* add cypress test for code-storage

* update test and storage epic

* fix Shaun's tired brain's logic

* refactor with suggestions

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* update codeReset

* increate cypress timeout because firefox is slow

* remove unused import to make linter happy

* use focus on editor

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* use more specific seletor for cypress editor test

* account for silly null challengeFiles

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
This commit is contained in:
Shaun Hamilton
2021-08-12 19:48:28 +01:00
committed by GitHub
parent 1f62dfe2b3
commit 59f17f237b
41 changed files with 916 additions and 910 deletions

View File

@@ -32,7 +32,7 @@ const propTypes = {
githubLink: PropTypes.string,
challengeType: PropTypes.number,
completedDate: PropTypes.number,
files: PropTypes.array
challengeFiles: PropTypes.array
})
),
createFlashMessage: PropTypes.func.isRequired,
@@ -136,7 +136,7 @@ const honestyInfoMessage = {
const initialState = {
solutionViewer: {
projectTitle: '',
files: null,
challengeFiles: null,
solution: null,
isOpen: false
}
@@ -167,17 +167,17 @@ export class CertificationSettings extends Component {
if (!completedProject) {
return null;
}
const { solution, githubLink, files } = completedProject;
const { solution, githubLink, challengeFiles } = completedProject;
const onClickHandler = () =>
this.setState({
solutionViewer: {
projectTitle,
files,
challengeFiles,
solution,
isOpen: true
}
});
if (files && files.length) {
if (challengeFiles?.length) {
return (
<Button
block={true}
@@ -417,7 +417,7 @@ export class CertificationSettings extends Component {
render() {
const {
solutionViewer: { files, solution, isOpen, projectTitle }
solutionViewer: { challengeFiles, solution, isOpen, projectTitle }
} = this.state;
const { t } = this.props;
@@ -434,7 +434,7 @@ export class CertificationSettings extends Component {
)}
{isOpen ? (
<ProjectModal
files={files}
challengeFiles={challengeFiles}
handleSolutionModalHide={this.handleSolutionModalHide}
isOpen={isOpen}
projectTitle={projectTitle}