From 5d946f3d776b634d9c74a25cf3c38796a12abdee Mon Sep 17 00:00:00 2001
From: sybiljasmine <51464288+sybiljasmine@users.noreply.github.com>
Date: Thu, 19 Sep 2019 21:22:09 +0530
Subject: [PATCH] valid factorial number update under the tests (#36792)
* valid factorial number update under the tests
* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* Removed redundant array in the tests
---
.../rosetta-code/factorial.english.md | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md b/curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md
index 0a911858e4..68057a7e63 100644
--- a/curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md
+++ b/curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md
@@ -35,11 +35,11 @@ tests:
- text: factorial(2) should return a number.
testString: assert(typeof factorial(2) === 'number');
- text: factorial(3) should return 6.
- testString: assert.equal(factorial(3),results[0]);
- - text: factorial(3) should return 120.
- testString: assert.equal(factorial(5),results[1]);
- - text: factorial(3) should return 3,628,800.
- testString: assert.equal(factorial(10),results[2]);
+ testString: assert.equal(factorial(3), 6);
+ - text: factorial(5) should return 120.
+ testString: assert.equal(factorial(5), 120);
+ - text: factorial(10) should return 3,628,800.
+ testString: assert.equal(factorial(10), 3628800);
```
@@ -59,15 +59,6 @@ function factorial(n) {
-### After Test
-
-
-```js
-const results=[6,120,3628800];
-```
-
-
-
## Solution