gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cleanup: typos and remove commented out code (#36573)

Browse Source
This commit is contained in:
xyozio
2019-08-09 21:27:26 +03:00
committed by mrugesh
parent 5db1f0d4c4
commit 657a5e2c16
6 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api-server/server/boot/certificate.js
View File

@ -436,7 +436,7 @@ function createShowCert(app) {
); );
let { completedDate = new Date() } = certChallenge || {}; let { completedDate = new Date() } = certChallenge || {};
// the challange id has been rotated for isDataVisCert // the challenge id has been rotated for isDataVisCert
// so we need to check for id 561add10cb82ac38a17513b3 // so we need to check for id 561add10cb82ac38a17513b3
if (certType === 'isDataVisCert' && !certChallenge) { if (certType === 'isDataVisCert' && !certChallenge) {
console.log('olderId'); console.log('olderId');

2
api-server/server/boot_tests/challenge.test.js
View File

@ -340,7 +340,7 @@ describe('boot/challenge', () => {
const mockHomeLocation = 'https://www.example.com'; const mockHomeLocation = 'https://www.example.com';
const mockLearnUrl = `${mockHomeLocation}/learn`; const mockLearnUrl = `${mockHomeLocation}/learn`;
it('redircts to the learn base url for non-users', async done => { it('redirects to the learn base url for non-users', async done => {
const redirectToCurrentChallenge = createRedirectToCurrentChallenge( const redirectToCurrentChallenge = createRedirectToCurrentChallenge(
() => {}, () => {},
{ _homeLocation: mockHomeLocation, _learnUrl: mockLearnUrl } { _homeLocation: mockHomeLocation, _learnUrl: mockLearnUrl }

4
api-server/server/middlewares/request-authorizaion.test.js
View File

@ -105,7 +105,7 @@ describe('request-authorization', () => {
const next = sinon.spy(); const next = sinon.spy();
expect(() => requestAuthorization(req, res, next)).toThrowError( expect(() => requestAuthorization(req, res, next)).toThrowError(
'Access token is no longer vaild' 'Access token is no longer valid'
); );
expect(next.called).toBe(false); expect(next.called).toBe(false);
}); });
@ -192,7 +192,7 @@ describe('request-authorization', () => {
const next = sinon.spy(); const next = sinon.spy();
expect(() => requestAuthorization(req, res, next)).toThrowError( expect(() => requestAuthorization(req, res, next)).toThrowError(
'Access token is no longer vaild' 'Access token is no longer valid'
); );
expect(next.called).toBe(false); expect(next.called).toBe(false);
}); });

4
api-server/server/middlewares/request-authorization.js
View File

@ -51,10 +51,10 @@ export default ({ jwtSecret = _jwtSecret, getUserById = _getUserById } = {}) =>
}); });
} }
if (!accessToken && error === errorTypes.expiredToken) { if (!accessToken && error === errorTypes.expiredToken) {
throw wrapHandledError(new Error('Access token is no longer vaild'), { throw wrapHandledError(new Error('Access token is no longer valid'), {
type: 'info', type: 'info',
redirect: `${homeLocation}/signin`, redirect: `${homeLocation}/signin`,
message: 'Access token is no longer vaild', message: 'Access token is no longer valid',
status: 403 status: 403
}); });
} }

2
api-server/server/server.js
View File

@ -40,7 +40,7 @@ const logOnce = createLogOnce();
boot(app, __dirname, err => { boot(app, __dirname, err => {
if (err) { if (err) {
// rethrowing the error here bacause any error thrown in the boot stage // rethrowing the error here because any error thrown in the boot stage
// is silent // is silent
logOnce('The below error was thrown in the boot stage'); logOnce('The below error was thrown in the boot stage');
throw err; throw err;

9
client/src/redux/rootReducer.js
View File

@ -20,15 +20,6 @@ import {
ns as searchNameSpace ns as searchNameSpace
} from '../components/search/redux'; } from '../components/search/redux';
// console.log({
// [appNameSpace]: app,
// [challengeNameSpace]: challenge,
// [curriculumMapNameSpace]: curriculumMap,
// [flashNameSpace]: flash,
// form: formReducer,
// [searchNameSpace]: search,
// [settingsNameSpace]: settings
// });
export default combineReducers({ export default combineReducers({
[appNameSpace]: app, [appNameSpace]: app,
[challengeNameSpace]: challenge, [challengeNameSpace]: challenge,