From a3e50050587c6585a397483ec9373d27a9ede0f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Djordje=20Lacmanovi=C4=87?= Date: Tue, 4 Aug 2015 16:51:10 +0200 Subject: [PATCH 1/4] fixed issue #1511 - now checking for words longer than 9 chars closes #1511 --- seed/challenges/basic-bonfires.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/seed/challenges/basic-bonfires.json b/seed/challenges/basic-bonfires.json index 8d97403e21..8fb64bc1c8 100644 --- a/seed/challenges/basic-bonfires.json +++ b/seed/challenges/basic-bonfires.json @@ -231,7 +231,8 @@ "expect(findLongestWord('The quick brown fox jumped over the lazy dog')).to.equal(6);", "expect(findLongestWord('May the force be with you')).to.equal(5);", "expect(findLongestWord('Google do a barrel roll')).to.equal(6);", - "expect(findLongestWord('What is the average airspeed velocity of an unladen swallow')).to.equal(8);" + "expect(findLongestWord('What is the average airspeed velocity of an unladen swallow')).to.equal(8);", + "expect(findLongestWord('What if we try a super-long word such as otorhinolaryngology')).to.equal(19);" ], "MDNlinks": [ "String.split()", From 52300b9648ce9267f94b6f8f0975ccdfc6e2ce81 Mon Sep 17 00:00:00 2001 From: ahstro Date: Thu, 6 Aug 2015 22:07:52 +0200 Subject: [PATCH 2/4] Changed test order & added in 'img to link' --- seed/challenges/html5-and-css.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/html5-and-css.json b/seed/challenges/html5-and-css.json index f4a11581d3..cad97a45bb 100644 --- a/seed/challenges/html5-and-css.json +++ b/seed/challenges/html5-and-css.json @@ -1259,8 +1259,8 @@ "Once you've done this, hover over your image with your cursor. Your cursor's normal pointer should become the link clicking pointer. The photo is now a link." ], "tests": [ + "assert($('a').children('img').length > 0, 'Nest your img element within an a element.')", "assert(new RegExp('#').test($('a').children('img').parent().attr('href')), 'Your a element should be a dead link with a href attribute set to \"#\".')", - "assert($('a').children('img').length > 0, 'Nest your image element within an a element.')", "assert(editor.match(/<\\/a>/g) && editor.match(//g).length === editor.match(/a elements has a closing tag.')" ], "challengeSeed": [ From fb2599b8fe63e8215adb5764864bfbed39863c4e Mon Sep 17 00:00:00 2001 From: ahstro Date: Thu, 6 Aug 2015 22:27:01 +0200 Subject: [PATCH 3/4] Grammatical error in 'Use Hex Code for Specific Colors' --- seed/challenges/html5-and-css.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/html5-and-css.json b/seed/challenges/html5-and-css.json index f4a11581d3..a08b9001f9 100644 --- a/seed/challenges/html5-and-css.json +++ b/seed/challenges/html5-and-css.json @@ -3402,7 +3402,7 @@ "dashedName": "waypoint-use-hex-code-for-specific-colors", "difficulty": 1.54, "description": [ - "Did you know there other ways to represent colors in CSS? One of these ways is called hexadecimal code, or \"hex code\" for short.", + "Did you know there are other ways to represent colors in CSS? One of these ways is called hexadecimal code, or \"hex code\" for short.", "\"Decimal\" means the numbers zero through nine - the numbers that people use in everyday life. \"Hexadecimal\" includes these 10 numbers, plus the letters A, B, C, D, E and F. This means that Hexidecimal has a total of 16 possible values, instead of the 10 possible values that our normal base-10 number system gives us.", "With CSS, we use 6 hexidecimal number to represent colors. For example, #000000 is the lowest possible value, and it represents the color black.", "Replace the word \"black\" in our body element's background-color with its \"hex code\" representation, #000000. " From 42321f5cef01e4795effda07e7bb8200401b35de Mon Sep 17 00:00:00 2001 From: ahstro Date: Thu, 6 Aug 2015 22:41:45 +0200 Subject: [PATCH 4/4] Wrong element in jQuery targeting waypoint --- seed/challenges/jquery-ajax-and-json.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/jquery-ajax-and-json.json b/seed/challenges/jquery-ajax-and-json.json index dad707f590..6c1fe0039f 100644 --- a/seed/challenges/jquery-ajax-and-json.json +++ b/seed/challenges/jquery-ajax-and-json.json @@ -60,7 +60,7 @@ "For example, let's make all of your button elements bounce. Just add this code inside your \"document ready function\": $('button').addClass('animated bounce')." ], "tests": [ - "assert($('button').hasClass('animated') && $('button').hasClass('bounce'), 'Use the jQuery addClass() function to give the classes \"animated\" and \"bounce\" to your img element.')", + "assert($('button').hasClass('animated') && $('button').hasClass('bounce'), 'Use the jQuery addClass() function to give the classes \"animated\" and \"bounce\" to your button element.')", "assert(!editor.match(/class.*animated/g), 'Only use jQuery to add these classes to the element.')" ], "challengeSeed": [