fix: remove redundant helper and guide code from Header
This commit is contained in:
committed by
mrugesh
parent
8ae0044682
commit
67d49efd1e
@ -9,12 +9,11 @@ import { Link } from '../helpers';
|
||||
import './header.css';
|
||||
|
||||
const propTypes = {
|
||||
disableSettings: PropTypes.bool,
|
||||
navigationMenu: PropTypes.element
|
||||
disableSettings: PropTypes.bool
|
||||
};
|
||||
|
||||
function Header(props) {
|
||||
const { disableSettings, navigationMenu } = props;
|
||||
const { disableSettings } = props;
|
||||
return (
|
||||
<header>
|
||||
<nav id='top-nav'>
|
||||
@ -22,11 +21,7 @@ function Header(props) {
|
||||
<NavLogo />
|
||||
</Link>
|
||||
{disableSettings ? null : <SearchBar />}
|
||||
{navigationMenu ? (
|
||||
navigationMenu
|
||||
) : (
|
||||
<NavigationMenu disableSettings={disableSettings} />
|
||||
)}
|
||||
</nav>
|
||||
</header>
|
||||
);
|
||||
|
@ -67,7 +67,6 @@ const propTypes = {
|
||||
isOnline: PropTypes.bool.isRequired,
|
||||
isSignedIn: PropTypes.bool,
|
||||
landingPage: PropTypes.bool,
|
||||
navigationMenu: PropTypes.element,
|
||||
onlineStatusChange: PropTypes.func.isRequired,
|
||||
pathname: PropTypes.string.isRequired,
|
||||
removeFlashMessage: PropTypes.func.isRequired,
|
||||
@ -131,7 +130,6 @@ class DefaultLayout extends Component {
|
||||
isOnline,
|
||||
isSignedIn,
|
||||
landingPage,
|
||||
navigationMenu,
|
||||
removeFlashMessage,
|
||||
showFooter = true
|
||||
} = this.props;
|
||||
@ -151,10 +149,7 @@ class DefaultLayout extends Component {
|
||||
<style>{fontawesome.dom.css()}</style>
|
||||
</Helmet>
|
||||
<WithInstantSearch>
|
||||
<Header
|
||||
disableSettings={landingPage}
|
||||
navigationMenu={navigationMenu}
|
||||
/>
|
||||
<Header disableSettings={landingPage} />
|
||||
<div
|
||||
className={`default-layout ${landingPage ? 'landing-page' : ''}`}
|
||||
>
|
||||
|
@ -1,12 +0,0 @@
|
||||
exports.getGithubPath = function getGithubPath(fileAbsolutePath) {
|
||||
const { NODE_ENV: env } = process.env;
|
||||
const guideType = env === 'production' ? 'guide' : 'mock-guide';
|
||||
let githubFilePath =
|
||||
'https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md#research-write-and-update-our-guide-articles';
|
||||
const pathIndex = fileAbsolutePath.indexOf(`/${guideType}`);
|
||||
if (pathIndex > -1) {
|
||||
const newPath = fileAbsolutePath.slice(pathIndex);
|
||||
githubFilePath = `https://github.com/freeCodeCamp/freeCodeCamp/blob/master${newPath}`;
|
||||
}
|
||||
return githubFilePath;
|
||||
};
|
Reference in New Issue
Block a user