gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: improve challenge logs (#39395)

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2020-08-11 16:32:18 +02:00
committed by GitHub
parent e1df87678b
commit 688a3dcc7b
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
client/src/client/workers/test-evaluator.js
View File

@ -32,11 +32,11 @@ const __utils = (() => {
self.postMessage(data); self.postMessage(data);
} }
function log(msg) { function log(...msgs) {
if (!(msg instanceof chai.AssertionError)) { if (msgs && msgs[0] && !(msgs[0] instanceof chai.AssertionError)) {
// discards the stack trace via toString as it only useful to debug the // discards the stack trace via toString as it only useful to debug the
// site, not a specific challenge. // site, not a specific challenge.
console.log(msg.toString()); console.log(...msgs.map(msg => msg.toString()));
} }
} }
@ -80,8 +80,15 @@ ${e.data.testString}`);
// rethrow error, since test failed. // rethrow error, since test failed.
throw err; throw err;
} }
// log build errors // log build errors unless they're related to import/export/require (there
__utils.log(err); // are challenges that use them and they should not trigger warnings)
if (
err.name !== 'ReferenceError' ||
(err.message !== 'require is not defined' &&
err.message !== 'exports is not defined')
) {
__utils.log(err);
}
// the tests may not require working code, so they are evaluated even if // the tests may not require working code, so they are evaluated even if
// the user code does not get executed. // the user code does not get executed.
testResult = eval(e.data.testString); testResult = eval(e.data.testString);