From 6caf034e70a8ae28efe32855d8d48c1f8238f871 Mon Sep 17 00:00:00 2001 From: dhcodes Date: Fri, 18 Aug 2017 15:23:39 -0500 Subject: [PATCH] fix(frame): Fix fcc-test-frame on firefox I used an alternative to display: none; to allow Firefox to properly run challenge tests Closes #10749 --- client/epics/frame-epic.js | 2 +- client/less/main.less | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/client/epics/frame-epic.js b/client/epics/frame-epic.js index f8dd19b0d9..3d7c142940 100644 --- a/client/epics/frame-epic.js +++ b/client/epics/frame-epic.js @@ -35,7 +35,7 @@ const createHeader = (id = mainId) => ` function createFrame(document, id = mainId) { const frame = document.createElement('iframe'); frame.id = id; - frame.setAttribute('style', 'display: none'); + frame.className = 'hide-test-frame'; document.body.appendChild(frame); return frame; } diff --git a/client/less/main.less b/client/less/main.less index 043d001eb2..6cf56077b9 100644 --- a/client/less/main.less +++ b/client/less/main.less @@ -126,6 +126,13 @@ h1, h2, h3, h4, h5, h6, p, li { margin: 2px; } +.hide-test-frame { + position: absolute; + top: -9999px; + left: -9999px; + visibility: hidden; +} + .landing-icon { height: 200px; width: 200px;