gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: prevent dev tools from accessing state in prod (#38669)

Browse Source 
* Fixed Redux dev tool plugin in production problem

* Update client/src/redux/createStore.js

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update client/src/redux/createStore.js

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update client/src/redux/createStore.js

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update client/src/redux/createStore.js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Fixed ESLint error

* Second try to fix linting issue

* Third try to fix lint issues

* Update client/src/redux/createStore.js

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/redux/createStore.js

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: use env.json for ENVIRONMENT

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
This commit is contained in:
Twaha Rahman
2020-08-20 01:52:59 +06:00
committed by GitHub
parent 0ee680c3ab
commit 7155c87e8b
3 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
client/gatsby-node.js
View File

@ -169,9 +169,6 @@ exports.onCreateWebpackConfig = ({ stage, plugins, actions }) => {
process.env.HOME_PATH || 'http://localhost:3000' process.env.HOME_PATH || 'http://localhost:3000'
), ),
STRIPE_PUBLIC_KEY: JSON.stringify(process.env.STRIPE_PUBLIC_KEY || ''), STRIPE_PUBLIC_KEY: JSON.stringify(process.env.STRIPE_PUBLIC_KEY || ''),
ENVIRONMENT: JSON.stringify(
process.env.FREECODECAMP_NODE_ENV || 'development'
),
PAYPAL_SUPPORTERS: JSON.stringify(process.env.PAYPAL_SUPPORTERS || 404) PAYPAL_SUPPORTERS: JSON.stringify(process.env.PAYPAL_SUPPORTERS || 404)
}) })
]; ];

18
client/src/redux/createStore.js
View File

@ -9,6 +9,8 @@ import rootReducer from './rootReducer';
import rootSaga from './rootSaga'; import rootSaga from './rootSaga';
import { isBrowser } from '../../utils'; import { isBrowser } from '../../utils';
import { environment } from '../../../config/env.json';
const clientSide = isBrowser(); const clientSide = isBrowser();
const sagaMiddleware = createSagaMiddleware({ const sagaMiddleware = createSagaMiddleware({
@ -29,10 +31,18 @@ const composeEnhancers = composeWithDevTools({
}); });
export const createStore = () => { export const createStore = () => {
const store = reduxCreateStore( let store;
rootReducer, if (environment === 'production') {
composeEnhancers(applyMiddleware(sagaMiddleware, epicMiddleware)) store = reduxCreateStore(
); rootReducer,
applyMiddleware(sagaMiddleware, epicMiddleware)
);
} else {
store = reduxCreateStore(
rootReducer,
composeEnhancers(applyMiddleware(sagaMiddleware, epicMiddleware))
);
}
sagaMiddleware.run(rootSaga); sagaMiddleware.run(rootSaga);
epicMiddleware.run(rootEpic); epicMiddleware.run(rootEpic);
if (module.hot) { if (module.hot) {

1
config/env.js
View File

@ -37,6 +37,7 @@ const locations = {
module.exports = Object.assign(locations, { module.exports = Object.assign(locations, {
locale, locale,
deploymentEnv, deploymentEnv,
environment: process.env.FREECODECAMP_NODE_ENV || 'development',
stripePublicKey: stripePublicKey:
!stripePublicKey || stripePublicKey === 'pk_from_stripe_dashboard' !stripePublicKey || stripePublicKey === 'pk_from_stripe_dashboard'
? null ? null