From 77bf5630f06c739a42ddcb1afcc5b8e84ecee7f3 Mon Sep 17 00:00:00 2001 From: Haile Lagi <52631736+obsessedyouth@users.noreply.github.com> Date: Thu, 3 Sep 2020 15:58:28 +0100 Subject: [PATCH] fix(learn): update helmet.js instructions for specific versioning (#39194) * fix(client): update middleware names of helmet.js tests * Revert "fix(client): update middleware names of helmet.js tests" This reverts commit 86d3bb2de8bbd2085939fc4af7b5356b9dc577e2. * fix: set helmet to v3.21.3 Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com> --- .../install-and-require-helmet.english.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.english.md b/curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.english.md index 129f5b3ba9..dbf927f3a1 100644 --- a/curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.english.md +++ b/curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.english.md @@ -14,7 +14,8 @@ Helmet helps you secure your Express apps by setting various HTTP headers. ## Instructions
-Install the Helmet package, then require it. + +Install Helmet version `3.21.3`, then require it.
## Tests @@ -22,8 +23,8 @@ Install the Helmet package, then require it. ```yml tests: - - text: '"helmet" dependency should be in package.json' - testString: getUserInput => $.get(getUserInput('url') + '/_api/package.json').then(data => { var packJson = JSON.parse(data); assert.property(packJson.dependencies, 'helmet'); }, xhr => { throw new Error(xhr.responseText); }) + - text: 'helmet version 3.21.3 should be in package.json' + testString: getUserInput => $.get(getUserInput('url') + '/_api/package.json').then(data => { var packJson = JSON.parse(data); assert(packJson.dependencies.helmet === '3.21.3' ); }, xhr => { throw new Error(xhr.responseText); }) ```