gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update copy for uncomment html. Fix iframe view covering up button in narrow width. Make iframe fixed so it's viewable as code editor expands and people scroll down. closes #596, closes #655

Browse Source
This commit is contained in:
terakilobyte
2015-05-27 15:15:28 -04:00
parent 6996467c72
commit 79b20d9798
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
public/css/main.less
View File

@ -1087,6 +1087,11 @@ hr {
color: @gray-light; color: @gray-light;
} }
.iframe-scroll {
position: fixed !important;
margin-top: 75px;
}
//uncomment this to see the dimensions of all elements outlined in red //uncomment this to see the dimensions of all elements outlined in red
//* { //* {
// border-color: red; // border-color: red;

5
seed_data/challenges/basic-html5-and-css.json
View File

@ -90,7 +90,8 @@
"Uncomment the <code>h1</code>, <code>h2</code> and <code>p</code> elements.", "Uncomment the <code>h1</code>, <code>h2</code> and <code>p</code> elements.",
"Commenting is a way that you can leave comments within your code without affecting the code itself.", "Commenting is a way that you can leave comments within your code without affecting the code itself.",
"Commenting is also a convenient way to make code inactive without having to delete it entirely.", "Commenting is also a convenient way to make code inactive without having to delete it entirely.",
"You can start a comment with <code>&#60;!--</code> and end a comment with <code>--&#62;</code>." "You can start a comment with <code>&#60;!--</code> and end a comment with <code>--&#62;</code>.",
"Lastly, someone's made a typo on one of the tags. Go ahead and fix it!"
], ],
"tests": [ "tests": [
"assert($('h1').length > 0, 'The h1 element should not be commented. It should be visible in the browser.')", "assert($('h1').length > 0, 'The h1 element should not be commented. It should be visible in the browser.')",
@ -101,7 +102,7 @@
"<!--", "<!--",
"<h1>Hello World</h1>", "<h1>Hello World</h1>",
"", "",
"<h2>CatPhotoApp</h2>", "<h>CatPhotoApp</h2>",
"", "",
"<br/>", "<br/>",
"", "",

4
views/coursewares/showHTML.jade
View File

@ -78,8 +78,8 @@ block content
textarea#codeEditor(autofocus=true, style='display: none;') textarea#codeEditor(autofocus=true, style='display: none;')
.col-md-4.col-lg-3 .col-md-4.col-lg-3
.hidden-xs.hidden-sm .hidden-xs.hidden-sm
img.iphone-position(src="https://s3.amazonaws.com/freecodecamp/iphone6-frame.png") img.iphone-position.iframe-scroll(src="https://s3.amazonaws.com/freecodecamp/iphone6-frame.png")
iframe.iphone#preview iframe.iphone.iframe-scroll#preview
#complete-courseware-dialog.modal(tabindex='-1') #complete-courseware-dialog.modal(tabindex='-1')
.modal-dialog.animated.zoomIn.fast-animation .modal-dialog.animated.zoomIn.fast-animation
.modal-content .modal-content