gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

add comments about failing tests for Nich.

Browse Source
This commit is contained in:
Shaun Hamilton
2021-12-01 20:42:40 +00:00
parent e927f887ba
commit 7af5b572c5
11 changed files with 196 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
curriculum/challenges/english/01-responsive-web-design/learn-css-flexbox-by-building-a-photo-gallery/step-016.md
View File

@ -14,6 +14,7 @@ Give your `#gallery` selector a `padding` property set to `0 4px`.
Your `#gallery` selector should have a `padding` property set to `0 4px`.
```js
// @nhcarrigan The following steps do not have this
assert.equal(new __helpers.CSSHelp(document).getStyle('#gallery')?.paddingTop, '0px');
assert.equal(new __helpers.CSSHelp(document).getStyle('#gallery')?.paddingBottom, '0px');
assert.equal(new __helpers.CSSHelp(document).getStyle('#gallery')?.paddingLeft, '4px');

2
curriculum/challenges/english/01-responsive-web-design/learn-css-grid-by-building-a-magazine/step-005.md
View File

@ -56,7 +56,7 @@ assert(document.querySelector('p')?.className === 'hero-subtitle');
Your `p` element should have the text set to `Our efforts to restructure our curriculum with a more project-based focus`.
```js
assert.equal(document.querySelector('p')?.textContent, 'Our efforts to restructure our curriculum with a more project-based focus');
assert.equal(document.querySelector('p')?.textContent?.trim(), 'Our efforts to restructure our curriculum with a more project-based focus');
```
# --seed--

1
curriculum/challenges/english/01-responsive-web-design/learn-css-grid-by-building-a-magazine/step-061.md
View File

@ -14,6 +14,7 @@ To give the `hr` a color, you need to adjust the `border` property. Give the `hr
Your `hr` should have a `border` property set to `1px solid rgba(120, 120, 120, 0.6)`.
```js
// @nhcarrigan The following steps do not have this
assert.equal(new __helpers.CSSHelp(document).getStyle('hr')?.borderWidth, '1px');
assert.equal(new __helpers.CSSHelp(document).getStyle('hr')?.borderStyle, 'solid');
assert.equal(new __helpers.CSSHelp(document).getStyle('hr')?.borderColor, 'rgba(120, 120, 120, 0.6)');

2
curriculum/challenges/english/01-responsive-web-design/learn-css-grid-by-building-a-magazine/step-080.md
View File

@ -16,7 +16,7 @@ Congratulations! Your magazine is now complete.
You should have a new `@media` query for `only screen and (max-width: 420px)`. This should be the last query in the `@media` query list.
```js
assert(new __helpers.CSSHelp(document).getCSSRules('media')?.[3]?.media?.mediaText === 'only screen and (max-width: 420px)');
assert.equal(new __helpers.CSSHelp(document).getCSSRules('media')?.[3]?.media?.mediaText, 'only screen and (max-width: 420px)');
```
Your new `@media` query should have a `.hero-title` selector.

1
curriculum/challenges/english/01-responsive-web-design/learn-intermediate-css-by-building-a-picasso-painting/step-029.md
View File

@ -14,6 +14,7 @@ These dots are just a little too square. Give the `black-dot` class a `border-ra
Your `.black-dot` selector should have a `border-radius` property set to `50%`.
```js
// @nhcarrigan This is not in the following steps
assert.equal(new __helpers.CSSHelp(document).getStyle('.black-dot')?.borderTopLeftRadius, '50%');
assert.equal(new __helpers.CSSHelp(document).getStyle('.black-dot')?.borderTopRightRadius, '50%');
assert.equal(new __helpers.CSSHelp(document).getStyle('.black-dot')?.borderBottomRightRadius, '50%');

2
curriculum/challenges/english/01-responsive-web-design/learn-intermediate-css-by-building-a-picasso-painting/step-089.md
View File

@ -385,7 +385,7 @@ body {
# --solutions--
```html
// TODO: Add solution once step 070 is fixed!
// TODO: Add solution once steps 029 and 070 is fixed!
```
```css

1
curriculum/challenges/english/01-responsive-web-design/learn-typography-by-building-a-nutrition-label/step-004.md
View File

@ -56,6 +56,7 @@ assert(links.find(link => link?.getAttribute('href') === 'https://fonts.googleap
<body>
<h1>Nutrition Facts</h1>
<p>8 servings per container</p>
<p>Serving size 2/3 cup (55g)</p>
</body>
</html>
--fcc-editable-region--

6
curriculum/challenges/english/01-responsive-web-design/learn-typography-by-building-a-nutrition-label/step-033.md
View File

@ -20,7 +20,11 @@ assert(new __helpers.CSSHelp(document).getStyle('.calories-info h1'));
Your new `.calories-info h1` selector should have a `margin` property set to `-5px 0`.
```js
assert(new __helpers.CSSHelp(document).getStyle('.calories-info h1')?.margin === '-5px 0px');
// @nhcarrigan The next step uses `-5px -2px`
assert.equal(new __helpers.CSSHelp(document).getStyle('.calories-info h1')?.marginTop, '-5px');
assert.equal(new __helpers.CSSHelp(document).getStyle('.calories-info h1')?.marginBottom, '-5px');
assert.equal(new __helpers.CSSHelp(document).getStyle('.calories-info h1')?.marginLeft, '0px');
assert.equal(new __helpers.CSSHelp(document).getStyle('.calories-info h1')?.marginRight, '0px');
```
# --seed--

4
curriculum/challenges/english/01-responsive-web-design/learn-typography-by-building-a-nutrition-label/step-064.md
View File

@ -12,7 +12,7 @@ Add a medium divider after your `.daily-value` element. Below that new divider,
Give the `p` element the following text:
```
The % Daily Value (DV) tells you how much a nutrient in a serving of food contributes to a daily diet. 2,000 calories a day is used for general nutrition advice.
* The % Daily Value (DV) tells you how much a nutrient in a serving of food contributes to a daily diet. 2,000 calories a day is used for general nutrition advice.
```
# --hints--
@ -45,7 +45,7 @@ assert(document.querySelector('.label')?.lastElementChild?.classList?.contains('
Your new `p` element should have the provided text.
```js
assert(document.querySelector('.label')?.lastElementChild?.innerText === 'The % Daily Value (DV) tells you how much a nutrient in a serving of food contributes to a daily diet. 2,000 calories a day is used for general nutrition advice.');
assert(document.querySelector('.label')?.lastElementChild?.innerText === '* The % Daily Value (DV) tells you how much a nutrient in a serving of food contributes to a daily diet. 2,000 calories a day is used for general nutrition advice.');
```
# --seed--

152
curriculum/challenges/english/01-responsive-web-design/learn-typography-by-building-a-nutrition-label/step-066.md
View File

@ -16,7 +16,10 @@ With these last changes, your nutrition label is complete!
Your `.note` selector should have a `padding` property set to `0 8px`.
```js
assert(new __helpers.CSSHelp(document).getStyle('.note')?.padding === '0px 8px');
assert.equal(new __helpers.CSSHelp(document).getStyle('.note')?.paddingTop, '0px');
assert.equal(new __helpers.CSSHelp(document).getStyle('.note')?.paddingBottom, '0px');
assert.equal(new __helpers.CSSHelp(document).getStyle('.note')?.paddingLeft, '8px');
assert.equal(new __helpers.CSSHelp(document).getStyle('.note')?.paddingRight, '8px');
```
Your `.note` selector should have a `text-indent` property set to `-8px`.
@ -173,3 +176,150 @@ p {
}
--fcc-editable-region--
```
# --solutions--
```html
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>Nutrition Label</title>
<link href="https://fonts.googleapis.com/css?family=Open+Sans:400,700,800" rel="stylesheet">
<link href="./styles.css" rel="stylesheet">
</head>
<body>
<div class="label">
<header>
<h1 class="bold">Nutrition Facts</h1>
<div class="divider"></div>
<p>8 servings per container</p>
<p class="bold">Serving size <span class="right">2/3 cup (55g)</span></p>
</header>
<div class="divider lg"></div>
<div class="calories-info">
<p class="bold sm-text">Amount per serving</p>
<h1>Calories <span class="right">230</span></h1>
</div>
<div class="divider md"></div>
<div class="daily-value sm-text">
<p class="right bold no-divider">% Daily Value *</p>
<div class="divider"></div>
<p><span class="bold">Total Fat</span> 8g <span class="bold right">10%</span></p>
<p class="indent no-divider">Saturated Fat 1g <span class="bold right">5%</span></p>
<div class="divider"></div>
<p class="indent no-divider"><i>Trans</i> Fat 0g</p>
<div class="divider"></div>
<p><span class="bold">Cholesterol</span> 0mg <span class="right bold">0%</span></p>
<p><span class="bold">Sodium</span> 160mg <span class="right bold">7%</span></p>
<p><span class="bold">Total Carbohydrate</span> 37g <span class="right bold">13%</span></p>
<p class="indent no-divider">Dietary Fiber 4g</p>
<div class="divider"></div>
<p class="indent no-divider">Total Sugars 12g</p>
<div class="divider dbl-indent"></div>
<p class="dbl-indent no-divider">Includes 10g Added Sugars <span class="right bold">20%</span>
<div class="divider"></div>
<p class="no-divider"><span class="bold">Protein</span> 3g</p>
<div class="divider lg"></div>
<p>Vitamin D 2mcg <span class="right">10%</span></p>
<p>Calcium 260mg <span class="right">20%</span></p>
<p>Iron 8mg <span class="right">45%</span></p>
<p class="no-divider">Potassium 235mg <span class="right">6%</span></p>
</div>
<div class="divider md"></div>
<p class="note">* The % Daily Value (DV) tells you how much a nutrient in a serving of food contributes to a daily diet. 2,000 calories a day is used for general nutrition advice.</p>
</div>
</body>
</html>
```
```css
* {
box-sizing: border-box;
}
html {
font-size: 16px;
}
body {
font-family: 'Open Sans', sans-serif;
}
.label {
border: 2px solid black;
width: 270px;
margin: 20px auto;
padding: 0 7px;
}
header h1 {
text-align: center;
margin: -4px 0;
letter-spacing: 0.15px
}
p {
margin: 0;
}
.divider {
border-bottom: 1px solid #888989;
margin: 2px 0;
clear: right;
}
.bold {
font-weight: 800;
}
.right {
float: right;
}
.lg {
height: 10px;
}
.lg, .md {
background-color: black;
border: 0;
}
.md {
height: 5px;
}
.sm-text {
font-size: 0.85rem;
}
.calories-info h1 {
margin: -5px -2px;
overflow: hidden;
}
.calories-info span {
font-size: 1.2em;
margin-top: -7px;
}
.indent {
margin-left: 1em;
}
.dbl-indent {
margin-left: 2em;
}
.daily-value p:not(.no-divider) {
border-bottom: 1px solid #888989;
}
.note {
font-size: 0.6rem;
margin: 5px 0;
padding: 0px 8px;
text-indent: -8px;
}
```