From 7b449e7a5b8567f61c87cf8a30927e8ed044dd1b Mon Sep 17 00:00:00 2001 From: Berkeley Martinez Date: Tue, 17 Mar 2015 20:39:27 -0700 Subject: [PATCH] Add returns to error handlers add missing next to arguments for middleware --- controllers/resources.js | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/controllers/resources.js b/controllers/resources.js index b2a19af446..ac6a044acd 100644 --- a/controllers/resources.js +++ b/controllers/resources.js @@ -29,28 +29,27 @@ module.exports = { sitemap: function sitemap(req, res, next) { var appUrl = 'http://www.freecodecamp.com'; - var now = moment(new Date).format('YYYY-MM-DD'); + var now = moment(new Date()).format('YYYY-MM-DD'); - errors = {}; User.find({'profile.username': {'$ne': '' }}, function(err, users) { if (err) { debug('User err: ', err); - next(err); + return next(err); } Challenge.find({}, function (err, challenges) { if (err) { debug('User err: ', err); - next(err); + return next(err); } Bonfire.find({}, function (err, bonfires) { if (err) { debug('User err: ', err); - next(err); + return next(err); } Story.find({}, function (err, stories) { if (err) { debug('User err: ', err); - next(err); + return next(err); } res.header('Content-Type', 'application/xml'); res.render('resources/sitemap', { @@ -189,12 +188,12 @@ module.exports = { User.count({}, function (err, c3) { if (err) { debug('User err: ', err); - next(err); + return next(err); } User.count({'points': {'$gt': 53}}, function (err, all) { if (err) { debug('User err: ', err); - next(err); + return next(err); } res.render('resources/learn-to-code', {