From c6b2140c023516e98ab2af6978cbd5c20d620d64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20Floty=C5=84ski?= Date: Thu, 6 Aug 2015 00:20:52 +0200 Subject: [PATCH 1/3] first fixes - length larger _or equal_ to 1 I'm not sure if the tests are too vague - they allow to comment out way more than just the text specified - like the whole page.. --- seed/challenges/bootstrap.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/seed/challenges/bootstrap.json b/seed/challenges/bootstrap.json index 5a89962f12..5cfb6f699d 100644 --- a/seed/challenges/bootstrap.json +++ b/seed/challenges/bootstrap.json @@ -2036,9 +2036,9 @@ "Add a comment at the top of your HTML that says You shouldn't need to modify code below this line." ], "tests": [ - "assert(editor.match(//g).length > 1, 'Be sure to close your comment with -->.')" + "assert(editor.match(//g).length >= 1, 'Be sure to close your comment with -->.')" ], "challengeSeed": [ "
", From 073456e0de4f99351ef2fde6b75d623d94b71e6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20Floty=C5=84ski?= Date: Thu, 6 Aug 2015 00:25:11 +0200 Subject: [PATCH 2/3] changed to agree with the style - greater than 0 instead of greater than or eqal to 1 --- seed/challenges/bootstrap.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/seed/challenges/bootstrap.json b/seed/challenges/bootstrap.json index 5cfb6f699d..ba2869359a 100644 --- a/seed/challenges/bootstrap.json +++ b/seed/challenges/bootstrap.json @@ -2036,9 +2036,9 @@ "Add a comment at the top of your HTML that says You shouldn't need to modify code below this line." ], "tests": [ - "assert(editor.match(//g).length >= 1, 'Be sure to close your comment with -->.')" + "assert(editor.match(//g).length > 0, 'Be sure to close your comment with -->.')" ], "challengeSeed": [ "
", From c577190e675f0ce77d512e59567423d2b4ced701 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20Floty=C5=84ski?= Date: Thu, 6 Aug 2015 00:57:55 +0200 Subject: [PATCH 3/3] Fixed tests Added check if the object isn't null and escaped quotes because text enclosed apostrophe --- seed/challenges/bootstrap.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/seed/challenges/bootstrap.json b/seed/challenges/bootstrap.json index ba2869359a..03c9ed18bd 100644 --- a/seed/challenges/bootstrap.json +++ b/seed/challenges/bootstrap.json @@ -2036,9 +2036,9 @@ "Add a comment at the top of your HTML that says You shouldn't need to modify code below this line." ], "tests": [ - "assert(editor.match(//g).length > 0, 'Be sure to close your comment with -->.')" + "assert(editor.match(//g) && editor.match(/-->/g).length > 0, 'Be sure to close your comment with -->.')" ], "challengeSeed": [ "
",