gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(a11y): add title attribute to iframes (#45014)

Browse Source 
* fix:add title attribute to iframes
This commit is contained in:
Bruce B
2022-02-08 02:22:54 -08:00
committed by GitHub
parent 5a25d0b847
commit 7d817cb237
2 changed files with 37 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
client/src/templates/Challenges/utils/build.js
View File

@@ -208,7 +208,13 @@ export function updateProjectPreview(buildData, document) {
buildData.challengeType === challengeTypes.html ||
buildData.challengeType === challengeTypes.multiFileCertProject
) {
createProjectPreviewFramer(document)(buildData);
// Give iframe a title attribute for accessibility using the preview
// document's <title>.
const titleMatch = buildData?.sources?.index?.match(
/<title>(.*?)<\/title>/
);
const frameTitle = titleMatch ? titleMatch[1] + ' preview' : 'preview';
createProjectPreviewFramer(document, frameTitle)(buildData);
} else {
throw new Error(
`Cannot show preview for challenge type ${buildData.challengeType}`