From 8498abc95a08b73d49a04ccf26a905eb30b02be3 Mon Sep 17 00:00:00 2001
From: Berkeley Martinez <berkeleytrue@users.noreply.github.com>
Date: Fri, 5 Jan 2018 15:45:17 -0800
Subject: [PATCH] fix(Panes): Fix rightPane isHidden shadow bound

a rightpane that is hidden would also provide a shadow barrier to
minimizing a pane just left of it.
---
 common/app/Panes/redux/index.js | 38 +++++++++++++++++++++++----------
 1 file changed, 27 insertions(+), 11 deletions(-)

diff --git a/common/app/Panes/redux/index.js b/common/app/Panes/redux/index.js
index d5e6c6c562..0cdf63d82e 100644
--- a/common/app/Panes/redux/index.js
+++ b/common/app/Panes/redux/index.js
@@ -100,7 +100,22 @@ function checkForTypeKeys(panesMap) {
   return panesMap;
 }
 
-const getPaneName = (panes, index) => (panes[index] || {}).name || '';
+const getPane = (panesByName, panes, index) => _.get(
+  panesByName,
+  getPaneName(panes, index),
+  null
+);
+
+const getPaneName = (panes, index) => _.get(
+  panes,
+  index,
+  ''
+);
+
+const createGetBound = isRight => (pane, buffer) =>
+  (pane && !pane.isHidden && pane.dividerLeft || (isRight ? 100 : 0)) - buffer;
+const getRightBound = createGetBound(true);
+const getLeftBound = createGetBound(false);
 
 function normalizePanesMapCreator(createPanesMap) {
   invariant(
@@ -156,19 +171,20 @@ export default function createPanesAspects({ createPanesMap }) {
           pressedDivider: name
         }),
         [types.dividerMoved]: (state, { payload: clientX }) => {
-          const { width, pressedDivider: paneName } = state;
+          const {
+            panes,
+            panesByName,
+            pressedDivider: paneName,
+            width
+          } = state;
           const dividerBuffer = (200 / width) * 100;
           const paneIndex =
             _.findIndex(state.panes, ({ name }) => paneName === name);
-          const currentPane = state.panesByName[paneName];
-          const rightPane =
-            state.panesByName[getPaneName(state.panes, paneIndex + 1)] || {};
-          const leftPane =
-            state.panesByName[getPaneName(state.panes, paneIndex - 1)] || {};
-          const rightBound = (rightPane.dividerLeft || 100) - dividerBuffer;
-          const leftBound =
-          (leftPane.isHidden || typeof leftPane.isHidden === 'undefined') ?
-          dividerBuffer : (leftPane.dividerLeft + dividerBuffer);
+          const currentPane = panesByName[paneName];
+          const rightPane = getPane(panesByName, panes, paneIndex + 1);
+          const leftPane = getPane(panesByName, panes, paneIndex - 1);
+          const rightBound = getRightBound(rightPane, dividerBuffer);
+          const leftBound = getLeftBound(leftPane, dividerBuffer);
           const newPosition = _.clamp(
             (clientX / width) * 100,
             leftBound,