fix: put error filtering in the handler
This commit is contained in:
committed by
Mrugesh Mohapatra
parent
f378f54ac3
commit
87ae387ecb
@ -1,19 +1,26 @@
|
|||||||
import { Handlers, captureException } from '@sentry/node';
|
import { Handlers, captureException } from '@sentry/node';
|
||||||
import { sentry } from '../../../config/secrets';
|
import { sentry } from '../../../config/secrets';
|
||||||
|
import { isHandledError } from '../utils/create-handled-error';
|
||||||
|
|
||||||
|
// sends directly to Sentry
|
||||||
export function reportError(err) {
|
export function reportError(err) {
|
||||||
return sentry.dns === 'dsn_from_sentry_dashboard'
|
return sentry.dns === 'dsn_from_sentry_dashboard'
|
||||||
? console.error(err)
|
? console.error(err)
|
||||||
: captureException(err);
|
: captureException(err);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// determines which errors should be reported
|
||||||
export default function sentryErrorHandler() {
|
export default function sentryErrorHandler() {
|
||||||
return sentry.dns === 'dsn_from_sentry_dashboard'
|
return sentry.dns === 'dsn_from_sentry_dashboard'
|
||||||
? (req, res, next) => next()
|
? (req, res, next) => next()
|
||||||
: Handlers.errorHandler({
|
: Handlers.errorHandler({
|
||||||
shouldHandleError(error) {
|
shouldHandleError(err) {
|
||||||
// NOTE: 400 is too low, this is just for debugging
|
// CSRF errors have status 403, consider ignoring them once csurf is
|
||||||
return !error.status || error.status >= 400;
|
// no longer rejecting people incorrectly.
|
||||||
|
return (
|
||||||
|
!isHandledError(err) &&
|
||||||
|
(!err.status || err.status === 403 || err.status >= 500)
|
||||||
|
);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user