gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor(client): explain transform's signature (#45166)

Browse Source 
It's important to not pass frame to transform when using
transformWithFrame. Instead we need to pass either frame.contentDocument
or frame.contentDocument.documentElement
This commit is contained in:
Oliver Eyton-Williams
2022-02-19 00:02:40 +01:00
committed by GitHub
parent 431bcbda10
commit 87f3d320ce
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
client/src/templates/Challenges/rechallenge/transformers.js
View File

@@ -211,8 +211,7 @@ async function transformScript(documentElement) {
// exist on the site, only in the editor
const addImportedFiles = async function (fileP) {
const file = await fileP;
const transform = frame => {
const documentElement = frame;
const transform = documentElement => {
const link =
documentElement.querySelector('link[href="styles.css"]') ??
documentElement.querySelector('link[href="./styles.css"]');
@@ -259,6 +258,10 @@ const transformWithFrame = async function (transform, contents) {
frame.contentDocument.documentElement.innerHTML = contents;
// grab the contents now, in case the transformation fails
out = { contents: frame.contentDocument.documentElement.innerHTML };
// it's important to pass around the documentElement and NOT the frame
// itself. It appears that the frame's documentElement can get replaced by a
// blank documentElement without the contents. This seems only to happen on
// Firefox.
out = await transform(frame.contentDocument.documentElement);
} finally {
document.body.removeChild(frame);